Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend repeat test for min=0 and default=1 #19472

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

it should be possible to execute tool without
any repeat elements.

but tool tests require a value for the data parameter even if no repeat is given.

I guess this broke in #17018 But if I revert the backend change tools do not
load anymore.

Also wondering why we use the legace branch in this if (even if I use a legacy tool profile).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Sorry, something went wrong.

it should be possible to execute tool without
any repeat elements.

but tool tests require a value for the data parameter
even if no repeat is given.

I guess this broke in galaxyproject#17018
But if I revert the backend change tools do not
load anymore.
@bernt-matthias bernt-matthias marked this pull request as draft January 28, 2025 13:15
@github-actions github-actions bot added this to the 25.0 milestone Jan 28, 2025
@jmchilton
Copy link
Member

Also wondering why we use the legace branch in this if (even if I use a legacy tool profile).

The legacy format for inputs is about how inputs are specified in the API and has nothing to do with the tool profile version. Legacy is also a bit a misnomer since it is used by tool tests, the tool form in the UI, required for various collection operations, etc... the newer input format was introduced missing a ton features of not really used anywhere except certain very specific API calls I think.

@bernt-matthias
Copy link
Contributor Author

Add API test like here:

def test_identifier_multiple_reduce_in_repeat(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants