-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read and Write GDML colour from/to BDSIM and generally. #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen reading gdml if available.
…Can be turned off, but shouldn't affect loading of any gdml anywhere.
…r an order of precedence for which vis options to take. Do not add hidden volumes (causes z fighting).
…g to be visible even if containers are read as not visible.
…x missing call to base class constructor.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 74.57% 74.61% +0.04%
==========================================
Files 157 157
Lines 22822 22867 +45
==========================================
+ Hits 17020 17063 +43
- Misses 5802 5804 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively simple addition to read aux tags in GDML for visualisation options.
Change of LogicalVolume to have no VisOptions instance by default (like PV). Defaults are enforced in the visualiser(s). This is an easier way to tell if one has been explicitly given, or default to materials, or default to supplied grey default. Works as previously expected, but loaded colours take precedence.
This will require the pull request from the test data to be accepted first. See: g4edge/testdata#32
Only with that, can I update the reference SHA1 commit ID here to use the new test file.
GDML with colour can be exported now from BDSIM with once that pull request is also merged.