Cleanup of unneeded locks in canvas objects #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
force-pushed
the
cleanup-of-unneeded-locks
branch
from
85dd286 to
6ecf5db
Compare
Jacalz
force-pushed
the
cleanup-of-unneeded-locks
branch
from
6ecf5db to
09446f7
Compare
|
Oh looks like it found a race on focusing in the window tests :( |
|
I feel like it is racing everywhere. Lots to be done to have Glfw tests passing 🥲 |
3 tasks
|
I think I got that fixed :) |
andydotxyz
previously approved these changes
Jan 13, 2025
|
It looks like CI running slower triggers more races than I can locally. Everything is green here but I fixed some more things that it found. Hopefully green soon. |
|
It appears like CI likely will be all green soon. I still expect races to be a bit flakey with more potting up later on but this seems to be a lot better. |
andydotxyz
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is work in progress changes for removing locks that no longer should be needed within canvas objects like canvas primitives, containers and widgets. With this one, all locks except the ones in widgets and their public base widget are removed. Further lock removals there might require #5384 to land first.
For #4654
Checklist: