Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

That's the races out of our test suite! #5384

Merged
merged 45 commits into from
Jan 11, 2025
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
8412c9d
Synchronise the theme watcher and other "background" items in test code
andydotxyz Jan 7, 2025
d35da3e
Refactored test package to not have races in the app settings applica…
andydotxyz Jan 8, 2025
5ae7d16
Resolve a race in the preference code
andydotxyz Jan 9, 2025
d28e1c5
Remove lock complications in test, they now behave better
andydotxyz Jan 9, 2025
145dd07
Correct race in mobile double tap handling
andydotxyz Jan 9, 2025
89f5f20
Remove locks and fix thread safety of cursor animation
andydotxyz Jan 9, 2025
b0e5c64
Move the window safety code into a wrapper type
andydotxyz Jan 9, 2025
08d798a
Fixes to canvas tests and what looked like 2 bad test files
andydotxyz Jan 9, 2025
00d741f
The final runOnMains for testing, and enable race checks in CI!
andydotxyz Jan 9, 2025
4c0458c
Merge branch 'develop' into fix/racedetection
andydotxyz Jan 9, 2025
7d5fb07
Fix merge conflict
andydotxyz Jan 9, 2025
367a6a6
Always use safe canvas in tests
andydotxyz Jan 9, 2025
895953c
Fix race in animation tests
andydotxyz Jan 9, 2025
13d1f77
Don't use goroutines in preference applciation
andydotxyz Jan 9, 2025
4713739
Add race to mobile and wayland
andydotxyz Jan 9, 2025
a0ecb94
Fixing some more window test races
andydotxyz Jan 9, 2025
98dc17d
Missed another goroutine
andydotxyz Jan 9, 2025
b97878b
Remove test that doesn't agree with pool contract
andydotxyz Jan 9, 2025
f3fbe55
Ensure it's not a race to start tests that is tripping mobile
andydotxyz Jan 9, 2025
e05f5ed
safety in window capture too
andydotxyz Jan 9, 2025
05919eb
More safety in tests
andydotxyz Jan 9, 2025
06b616b
Correcting test harness to fully run mobile and fix threading of doub…
andydotxyz Jan 10, 2025
d4f57b7
Be consistent with GLFW and wait for the main request
andydotxyz Jan 10, 2025
6d8675d
Attempting full mobile run
andydotxyz Jan 10, 2025
ddacc2c
Merge branch 'develop' into fix/racedetection
andydotxyz Jan 10, 2025
fb997d8
More safety in preference write
andydotxyz Jan 10, 2025
afb5db5
Lighter weight mobile test - more than before this PR but not the ful…
andydotxyz Jan 10, 2025
52a15d9
Potential issue with preferences and mobile
andydotxyz Jan 10, 2025
a446af3
Adjusting thread on file watcher callbacks
andydotxyz Jan 10, 2025
154d1e6
Fix staticcheck
andydotxyz Jan 10, 2025
c2f8169
More GLFW fixes
andydotxyz Jan 10, 2025
2b9f46d
Correct threading of cloud apply test
andydotxyz Jan 10, 2025
b37b4a5
Don't "find" app files for dialog tests
andydotxyz Jan 10, 2025
df498a6
Fix a race in menu bar tests on Ubuntu
andydotxyz Jan 10, 2025
49cbf18
Menu item safety for Ubuntu tests too
andydotxyz Jan 10, 2025
190d747
GLFW tests need real main thread
andydotxyz Jan 10, 2025
f04b0c9
Remove last worrying goroutines
andydotxyz Jan 10, 2025
6cec612
Same fix avoiding import loop
andydotxyz Jan 10, 2025
1ae8045
Safer tapping around in GLFW tests
andydotxyz Jan 10, 2025
bcb6742
Protecting more complex tap flows
andydotxyz Jan 10, 2025
15b454e
Passing locally on Linux now too
andydotxyz Jan 10, 2025
7dbcac0
Fixing some intermittent
andydotxyz Jan 10, 2025
62d9f9a
Fixing another occasional race
andydotxyz Jan 10, 2025
96a595f
Tidying from PR feedback
andydotxyz Jan 11, 2025
6369f2a
Correct done pool usage
andydotxyz Jan 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix staticcheck
andydotxyz committed Jan 10, 2025
commit 154d1e6b9ea525d425f62e1f207635391d9fbf1b
7 changes: 2 additions & 5 deletions internal/driver/mobile/canvas_test.go
Original file line number Diff line number Diff line change
@@ -510,11 +510,8 @@ func (a *mobileApp) Driver() fyne.Driver {
func (a *mobileApp) Run() {
// This is an incomplete driver loop - our CI does not currently support booting the mobile graphics
// TODO replace with a full mobileApp.Run() once that is resolved
for {
select {
case fn := <-d.queuedFuncs.Out():
fn()
}
for fn := range d.queuedFuncs.Out() {
fn()
}
}