driver/glfw: Merge waitForStart and done channels #5327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the threading changes, we no longer need to have separate channels for done and waitForStart given that showing a window no longer is expected to happen on the wrong thread. This allows allows us to first wait for starting and then reopen the channel to wait for shutting down.
andydotxyz
reviewed
Dec 17, 2024
| @@ -32,10 +32,6 @@ func ensureCanvasSize(t *testing.T, w *window, size fyne.Size) { | |||
| } | |||
|
|
|||
| func repaintWindow(w *window) { | |||
| // Wait for GLFW loop to be running. | |||
There was a problem hiding this comment.
are you sure this can be removed? I have a vague recollection this may have been an order-of-operations issue in the tests, so may not be disposable
|
Better solution was implemented in #5328 (review). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With the threading changes, we no longer need to have separate channels for done and waitForStart given that showing a window no longer is expected to happen on the wrong thread. This allows allows us to first wait for starting and then reopen the channel to wait for shutting down. I.e. we no longer carry around a useless startup channel once we are running.
Follow up to #5322
Checklist: