-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sd 118 inference update morgan #47
base: develop
Are you sure you want to change the base?
Conversation
… wrapper class for devices both compatible and incompatible with CUDA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments about bringing back metrics calculation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. Nice work 🔥
This setup should allow you to execute measurement scripts for local development purposes, e.g.: | ||
|
||
``` | ||
python measure_inference_power.py \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, my uv version was outdated. Updating uv works now.
return self.event.elapsed_time(n_event.event) | ||
return 0 | ||
|
||
def synchronize(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this here? Since we can just call torch.cuda.synchronize()
.
with open(file_path, "w", encoding="utf-8") as outfile: | ||
json.dump(results.model_dump(), outfile, indent=4) | ||
except Exception as e: | ||
print(f"An error occured during benchmarking: {e}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
occurred*
DESCRIPTION
--disable-power-measurement
flag to skip power logs