-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SD-88] Create unit test for creating training input features #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small nit, can be merged afterwards 👍
@@ -34,12 +34,12 @@ def test_compute_layer_metrics_by_cycle( | |||
model_name: str, data_preprocessor: DataPreprocessor | |||
) -> None: | |||
"""Test compute_layer_metrics_by_cycle.""" | |||
model_dir = Path(__file__).parent / "example_raw_data" / model_name | |||
model_dir = f"{BASE_DIR}/{model_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we still use Path syntaxis here and below?
model_dir = f"{BASE_DIR}/{model_name}" | |
model_dir = BASE_DIR / model_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added it in.
…ng data (#31) * Add dummy integration tests * Add integration tests * Add additional tests
In this PR, we add unit test to test if input features are parsed correctly from a TensorRT engine file for each layer type : convolutional, pooling and dense.