Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-88] Create unit test for creating training input features #32

Merged
merged 13 commits into from
Dec 19, 2024

Conversation

dudeperf3ct
Copy link
Member

@dudeperf3ct dudeperf3ct commented Dec 18, 2024

In this PR, we add unit test to test if input features are parsed correctly from a TensorRT engine file for each layer type : convolutional, pooling and dense.

@dudeperf3ct dudeperf3ct changed the title [SD-88] Create unit test for creating training input features #30 [SD-88] Create unit test for creating training input features Dec 18, 2024
@dudeperf3ct dudeperf3ct requested a review from d-lowl December 18, 2024 12:35
@dudeperf3ct dudeperf3ct self-assigned this Dec 18, 2024
Copy link
Member

@d-lowl d-lowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit, can be merged afterwards 👍

@@ -34,12 +34,12 @@ def test_compute_layer_metrics_by_cycle(
model_name: str, data_preprocessor: DataPreprocessor
) -> None:
"""Test compute_layer_metrics_by_cycle."""
model_dir = Path(__file__).parent / "example_raw_data" / model_name
model_dir = f"{BASE_DIR}/{model_name}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we still use Path syntaxis here and below?

Suggested change
model_dir = f"{BASE_DIR}/{model_name}"
model_dir = BASE_DIR / model_name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it in.

@dudeperf3ct dudeperf3ct merged commit 6d8ac68 into develop Dec 19, 2024
1 check passed
@dudeperf3ct dudeperf3ct deleted the SD-88-unit-test-training-data branch December 19, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants