Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-72] Add Github Actions workflows #29

Merged
merged 14 commits into from
Dec 19, 2024
Merged

[SD-72] Add Github Actions workflows #29

merged 14 commits into from
Dec 19, 2024

Conversation

osw282
Copy link
Contributor

@osw282 osw282 commented Dec 13, 2024

This PR creates a new workflow for running tests defined in the model training folder in CI when there are any changes to python files pushed to the PR or when the PR is first opened.

@osw282 osw282 marked this pull request as draft December 13, 2024 11:59
@osw282 osw282 marked this pull request as ready for review December 13, 2024 11:59
@osw282 osw282 marked this pull request as draft December 13, 2024 12:04
@osw282 osw282 marked this pull request as ready for review December 13, 2024 12:04
@osw282 osw282 marked this pull request as draft December 13, 2024 12:05
@osw282 osw282 marked this pull request as ready for review December 13, 2024 12:05
@osw282 osw282 marked this pull request as draft December 13, 2024 12:07
@osw282 osw282 marked this pull request as ready for review December 13, 2024 12:07
@osw282 osw282 self-assigned this Dec 13, 2024
working-directory: model_training

jobs:
file-changes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't require a new job for this. It should work using paths argument.

on:
  pull_request:
    types: [opened, ready_for_review, synchronize, reopened]
    branches:
      - main
      - develop
     paths: 'model_training/**/*.py'
  push:
    branches:
      - main
      - develop
    paths: 'model_training/**/*.py'

Copy link
Member

@d-lowl d-lowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Shubham, the file change detection can be simplified. Otherwise gtg

@osw282 osw282 requested review from dudeperf3ct and d-lowl December 19, 2024 11:19
@osw282 osw282 merged commit 77176dc into develop Dec 19, 2024
@osw282 osw282 deleted the SD-72-ci-for-test branch December 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants