Update apollo to 4.0.0 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejsemancik
requested changes
Sep 17, 2024
Comment on lines
131
to
143
| if (response.hasErrors()) { | ||
| throw NetworkError.CloudError( | ||
| code = errorResponseParser.getErrorResponseCode(response), | ||
| message = errorResponseParser.getErrorMessage(response) ?: "", | ||
| message = errorResponseParser.getErrorMessage(response), | ||
| ) | ||
| } | ||
|
|
||
| // Non-compliant server, if data is null, there should be at least one error | ||
| throw NetworkError.CloudError( | ||
| code = errorResponseParser.getErrorResponseCode(response), | ||
| message = errorResponseParser.getErrorMessage(response), | ||
| ) | ||
| } |
There was a problem hiding this comment.
This two throws are duplicated and can be merged into single throw
// Non-compliant server, if data is null, there should be at least one error, or
// A GraphQL request error happened or a Graph field error bubbled up.
throw NetworkError.CloudError(
code = errorResponseParser.getErrorResponseCode(response),
message = errorResponseParser.getErrorMessage(response)
)
matejsemancik
previously approved these changes
Sep 23, 2024
matejsemancik
approved these changes
Sep 23, 2024
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.