clearer closed messages #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far! A couple of corresponding tests will need to be broken out to check for each of these cases. |
anadon
pushed a commit
to furpocalypse/APIS
that referenced
this pull request
Dec 23, 2024
* update closed message on attendee reg * add to dealers and staff * fix existing tests * new tests for index * add tests to dealers * add staff tests * add test to onsite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messages just saying "closed" whenever not open is too clunky. now it says whether it hasnt opened yet or has ended. based on times specified for open and close for each section compared to current servertime date