Skip to content

Commit

Permalink
better explanations of ignored tests
Browse files Browse the repository at this point in the history
  • Loading branch information
arshaw committed Mar 2, 2024
1 parent a680883 commit 6300d97
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
####################################################################################################
# Intl
####################################################################################################

# NOT-IMPLEMENTED
# We do not reject legacy ICU time zone IDs
# For options passed to Intl.DateTimeFormat, we do not reject legacy ICU `timeZone`.
#
# Older versions of Node naturally fail on these IDs (ironically more compliant)
# Newer versions of Node accept them (ironically less compliant)
#
intl402/DateTimeFormat/timezone-legacy-non-iana.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Really picky about whitespace between characters
# Nothing we can do about this since it relies on Intl.DateTimeFormat
# Don't try to workaround buggy behavior in Node 18-20
# Caused by https://bugs.chromium.org/p/chromium/issues/detail?id=1416538
# Remove these lines after that bug is fixed.
staging/Intl402/Temporal/old/date-time-format.js
staging/Intl402/Temporal/old/datetime-toLocaleString.js
staging/Intl402/Temporal/old/instant-toLocaleString.js
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,8 @@ built-ins/Temporal/Duration/prototype/round/calendar-dateadd-called-with-plainda
intl402/DateTimeFormat/timezone-case-insensitive.js
intl402/DateTimeFormat/timezone-not-canonicalized.js

# NOT-IMPLEMENTED
# Intl.DateTimeFormat does not accept numeric-offset `timeZones`s and we are okay with that
# These are caught by the default test glob, but are unrelated to Temporal.
# They rely on Intl.DateTimeFormat supporting offset time zones.
intl402/DateTimeFormat/prototype/format/offset-timezone-gmt-same.js
intl402/DateTimeFormat/prototype/formatToParts/offset-timezone-correct.js
intl402/DateTimeFormat/prototype/resolvedOptions/offset-timezone-basic.js
Expand Down

0 comments on commit 6300d97

Please sign in to comment.