-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to mkdocs from Sphinx #135
Conversation
I would love a review of the live preview. I will admit I am a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 88.38% 88.38%
=======================================
Files 16 16
Lines 1773 1773
Branches 377 377
=======================================
Hits 1567 1567
Misses 136 136
Partials 70 70 ☔ View full report in Codecov by Sentry. |
I took a quick look at the live preview. Overall, I like the layout and functionality! Dark ModeThis could be a future enhancement, but a dark mode toggle and defaulting to "auto" to match system settings would be great: https://www.mkdocs.org/user-guide/choosing-your-theme/. Leftover StylingI think there's some leftover styling that displays oddly. There are a handful of ":class: https://fgpyo--135.org.readthedocs.build/en/135/reference/fgpyo/index.html#fgpyo.fastx.FastxZipped-functions ":py:obj:" seems like a styling leftover too. https://fgpyo--135.org.readthedocs.build/en/135/reference/fgpyo/index.html#fgpyo.fastx--zipping-fastx-files Installation PageLooks like some differences in how to reference page titles. https://fgpyo--135.org.readthedocs.build/en/135/installation.html |
After poking for a few minutes at the live preview - I like it a lot! I really like:
Big usability improvement from my perspective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a quick pass through. Overall I think this is an improvement, but I have several thoughts:
- Personally I really like the Markdown over RST - I think it's more readable likely less fragile.
- I think we can and should strike all the "Module Contents" sections from the docs. The right-nav on the module page does a good job of this automatically and we've always struggled to keep these sections up to date as new things get added.
- I really wish there was a better mechanism for linking to other python symbols vs. including a relative markdown link.
- The script for auto-discovering modules etc. - I would love for this to be something that is parameterized, and better documented, and then sharable either from fgpyo or as a standalone repo that can be sub-moduled in or something, rather than copy/pasting it between repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a big step forward on usability of the docs, and maintainability too!
docs: update docstrings for proper indentation tests: move tests to their own directory
My plan for making the
This may take a little while, but in the meantime I will merge this PR. |
There are a lot of changes required for this PR, most of them minor: