-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix executeActionsEmail via explicit ContentType declaration #142
Fix executeActionsEmail via explicit ContentType declaration #142
Conversation
…endpoint to comply with keycloak api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 99.26% 99.26% -0.01%
==========================================
Files 27 27
Lines 820 816 -4
==========================================
- Hits 814 810 -4
Misses 6 6 ☔ View full report in Codecov by Sentry. |
I think I broke this with this change: https://github.com/fschmtt/keycloak-rest-api-client-php/pull/136/files#diff-89227d64a8c020db74ce710e36b3a1b780a01fce857a4bbf524f58c8ef1014beR25-R35 I thought that we can safely use the I'd keep your change to provide the |
Do you mind if I take your PR and make some adjustments to your changes? |
Feel free to do so :) |
I couldn't help myself and already did, would be great if you could help me out here: #143 (comment) 🙂 |
Hey man, I merged your PR, thanks for contributing! 🎉 I'll release a new version in a minute. |
Unfortunately the executeActionsEmail endpoint is not working right now as it does not comply with the Keycloak Api. This is because of the behaviour of the CommandExecutor which would use the application/x-www-form-urlencoded ContentType whenever only an array is defined as Payload. For the executeActionsEmail endpoint only an Array of Actions is required but Keycloak expects an application/json Content-Type. Therefore i added the (fully optional) possibility to specify the ContentType explicitly when creating the Command. By now i only updated the one Command with which i had issues - maybe this issues applies to some other endpoints as well.