Fix beta deployments #2637
Fix beta deployments #2637
Conversation
WalkthroughThe pull request modifies three GitHub Actions workflow files (beta-go-release.yml, beta-sro-release.yml, and beta-zo-release.yml) by changing the parameter name from Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[sr-frontend] [Mon Jan 27 23:58:07 UTC 2025] - Deployed ee1a1cb to https://genshin-optimizer-prs.github.io/pr/2637/sr-frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Mon Jan 27 23:58:26 UTC 2025] - Deployed ee1a1cb to https://genshin-optimizer-prs.github.io/pr/2637/zzz-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Mon Jan 27 23:58:44 UTC 2025] - Deployed ee1a1cb to https://genshin-optimizer-prs.github.io/pr/2637/frontend (Takes 3-5 minutes after this completes to be available) [Tue Jan 28 00:09:40 UTC 2025] - Deleted deployment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/beta-sro-release.yml (1)
19-19: Architecture Note: Systematic improvement in variable handling.The consistent rename from
repo_nametorepo_var_nameacross all beta release workflows represents an architectural improvement in how repository variables are handled. Instead of passing the variable value directly, the workflows now pass the variable name, allowing the reusable workflow to handle variable resolution internally. This approach:
- Centralizes variable resolution logic in the reusable workflow
- Makes the variable handling more consistent across different deployments
- Potentially fixes issues with variable resolution timing in beta deployments
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/beta-go-release.yml(1 hunks).github/workflows/beta-sro-release.yml(1 hunks).github/workflows/beta-zo-release.yml(1 hunks)
🔇 Additional comments (2)
.github/workflows/beta-go-release.yml (1)
19-19: Verify the parameter change in build-frontend.yml workflow.The change from passing the variable value to passing the variable name suggests that the reusable workflow
build-frontend.ymlhas been updated to handle variable resolution internally. Let's verify this change:✅ Verification successful
Parameter change is correctly implemented and consistent
The change to use
repo_var_nameis properly implemented inbuild-frontend.ymland all dependent workflows are using the new parameter style consistently.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check the reusable workflow for corresponding changes # Check how the repo_var_name parameter is defined and used in build-frontend.yml echo "Checking build-frontend.yml for parameter definition and usage:" rg -A 5 'repo_var_name|repo_name' .github/workflows/build-frontend.yml # Look for any related changes in other workflow files echo -e "\nChecking for any other workflows that might need similar updates:" rg -l 'repo_name:\s*\${{.*}}' .github/workflows/Length of output: 1163
Script:
#!/bin/bash # Check for any other workflows that might need similar updates with fixed regex echo "Checking other workflows using repo_name parameter:" rg -l 'repo_name:.*\$\{\{' .github/workflows/ echo -e "\nChecking other workflows using repo_var_name parameter:" rg -l 'repo_var_name:' .github/workflows/Length of output: 663
.github/workflows/beta-zo-release.yml (1)
19-19: LGTM! Consistent with other workflow changes.The parameter rename from
repo_nametorepo_var_nameis consistent with the changes in other beta release workflows.
| @@ -16,6 +16,6 @@ jobs: | |||
| with: | |||
| frontend_name: 'sr-frontend' | |||
| deployment_name: 'beta' | |||
| repo_name: ${{ vars.PR_REPO }} | |||
| repo_var_name: 'PR_REPO' | |||
There was a problem hiding this comment.
💡 Codebase verification
The parameter rename is correctly implemented, but all beta deployments are failing due to a syntax error in the shared build-frontend.yml workflow. The 'Build frontend' step has an incomplete command where environment variables are set but no actual command is specified:
- name: Build frontend
run: |
NX_URL_GITHUB_GO_CURRENT_VERSION="https://github.com/${{ github.repository }}/commit/$(git rev-parse HEAD)" \
NX_DAEMON="false" \
NX_SHOW_DEV_COMPONENTS="${{inputs.show_dev_components}}" \🔗 Analysis chain
LGTM! Completes the systematic update across all beta workflows.
The parameter rename from repo_name to repo_var_name has been consistently applied across all beta release workflows. This systematic update suggests a fix for how repository variables are handled during beta deployments.
To ensure this change actually fixes beta deployments, let's check the deployment history:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check recent deployment history and any related issues
# Check recent workflow runs for these files
gh run list --workflow beta-go-release.yml --limit 5
gh run list --workflow beta-zo-release.yml --limit 5
gh run list --workflow beta-sro-release.yml --limit 5
# Look for related issues about beta deployments
gh issue list --search "beta deploy" --state all --limit 5
Length of output: 2256
Script:
#!/bin/bash
# Get detailed logs for the most recent failed runs
gh run view 13000596375 --log # GO
gh run view 13000596379 --log # ZO
gh run view 13000596350 --log # SRO
Length of output: 206
Script:
#!/bin/bash
# Check the workflow file content and any reusable workflows it references
cat .github/workflows/beta-sro-release.yml
fd -e yml -e yaml "reusable.*beta.*workflow" .github/workflows/
Length of output: 604
Script:
#!/bin/bash
# Check the reusable workflow content
cat .github/workflows/build-frontend.yml
Length of output: 3735
Describe your changes
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.Summary by CodeRabbit