Replace misread characters while parsing substat #2576
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The change aims to solve the issue where in substat image the OCR detects
+
as#
. It adds a list of replacements and replaces the text according to that list. The list can be extended to add new replacements. As of now only # -> + replacement is added.Issue or discord link
Testing/validation
Did functional tested using screenshots provided in the issue. Sampled my own genshin artifacts.
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
I have made corresponding changes to README or wiki.For front-end changes, I have updated the corresponding English translations.yarn run mini-ci
locally to validate format and lint.If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed