fixing issue #2525: Finale of the Deep use wrong conditional string

[davidkwonh]

Describe your changes

changed afterUse.skill, not hitOp.skill

in

genshin-optimizer/libs/gi/sheets/src/Weapons/Sword/FinaleOfTheDeep/index.tsx

Issue or discord link

#2525

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

• [ X] I have commented my code in hard-to understand areas.
• [ X] I have made corresponding changes to README or wiki.
• [ X] For front-end changes, I have updated the corresponding English translations.
• [ X] I have run yarn run mini-ci locally to validate format and lint.
• [ X] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Summary by CodeRabbit

• New Features
  • Updated the label for the skill's conditional effect in the Finale of the Deep weapon module to enhance clarity.

[coderabbitai]

Walkthrough

The changes involve a modification to the name property within the sheet object of the FinaleOfTheDeep weapon module. The name value for the first conditional entry has been updated from st('hitOp.skill') to st('afterUse.skill'), reflecting a change in terminology. There are no other alterations to logic, error handling, or control flow in this update.

Changes

File Path	Change Summary
libs/gi/sheets/src/Weapons/Sword/FinaleOfTheDeep/index.tsx	Updated name property from st('hitOp.skill') to st('afterUse.skill') in the sheet object.

Suggested reviewers

• frzyc

🐇 "In the realm of swords so deep,
A name was changed, a skill to keep.
From 'hitOp' to 'afterUse' it flows,
A shift in words, as the rabbit knows.
With every tweak, our tales we weave,
In the world of magic, we believe!" 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 12298ec and 218e259.

📒 Files selected for processing (1)

• libs/gi/sheets/src/Weapons/Sword/FinaleOfTheDeep/index.tsx (1 hunks)

🔇 Additional comments (1)

libs/gi/sheets/src/Weapons/Sword/FinaleOfTheDeep/index.tsx (1)

64-64: LGTM! The conditional string change aligns with the PR objective.

The change from hitOp.skill to afterUse.skill correctly addresses issue #2525 and provides a more accurate description of when the weapon effect triggers.

Let's verify the translation key exists and check for consistency with other weapon sheets:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

[frontend] [Fri Nov 8 04:27:27 UTC 2024] - Deployed d56f80d to https://genshin-optimizer-prs.github.io/pr/2534/frontend (Takes 3-5 minutes after this completes to be available)

[Sun Nov 10 15:26:27 UTC 2024] - Deleted deployment