Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRO Pando memberIndex -> characterKey #2513

Merged
merged 1 commit into from
Oct 21, 2024
Merged

SRO Pando memberIndex -> characterKey #2513

merged 1 commit into from
Oct 21, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Oct 21, 2024

Describe your changes

  • Change the reference to "characters" from member index to character keys, in both the data representation in the pando engine as well as database, which simplifies UI logic.

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc added the SRO For Star Rail Optimizer label Oct 21, 2024
@frzyc frzyc requested review from lantua and nguyentvan7 October 21, 2024 03:26
Copy link
Contributor

github-actions bot commented Oct 21, 2024

[sr-frontend] [Mon Oct 21 03:29:33 UTC 2024] - Deployed e38d770 to https://genshin-optimizer-prs.github.io/pr/2513/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Mon Oct 21 03:56:37 UTC 2024] - Deleted deployment

@frzyc frzyc merged commit 459f1d4 into master Oct 21, 2024
9 checks passed
@frzyc frzyc deleted the memberindex_to_charkey branch October 21, 2024 03:55
macerator-yaro pushed a commit to macerator-yaro/genshin-optimizer that referenced this pull request Oct 29, 2024
macerator-yaro pushed a commit to macerator-yaro/genshin-optimizer that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SRO For Star Rail Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants