Remove submodule checkout for release build #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sr-frontend] [Thu Oct 17 03:55:54 UTC 2024] - Deployed 92c1c74 to https://genshin-optimizer-prs.github.io/pr/2507/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Thu Oct 17 03:57:07 UTC 2024] - Deployed 92c1c74 to https://genshin-optimizer-prs.github.io/pr/2507/frontend (Takes 3-5 minutes after this completes to be available) [Thu Oct 17 17:54:37 UTC 2024] - Deleted deployment |
frzyc
approved these changes
Oct 17, 2024
|
It's cause I thought it was a hard requirement for release, but then I remembered we checked in all generated files now, even strings |
macerator-yaro
pushed a commit
to macerator-yaro/genshin-optimizer
that referenced
this pull request
Oct 29, 2024
macerator-yaro
pushed a commit
to macerator-yaro/genshin-optimizer
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
It wasn't used since we changed to checking in all generated files
I am not sure why CI gen-file check doesn't fail when doing the sparse checkout of StarRailData. I assume it might be because of the cache being used? But it is possible that might break at some point
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.