Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various issues #2493

Merged
merged 7 commits into from
Oct 12, 2024
Merged

Fix various issues #2493

merged 7 commits into from
Oct 12, 2024

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Oct 12, 2024 •
edited
Loading

Describe your changes

  • Fix duration of Scroll set
  • Fix HMR issues (See Fix Hot Module Reload #2321)
  • Fix duration of Clorinde skill + blade interval
  • Fix inconsistent spacing between text and node fields in field display
  • Fix Sethos CA and PA multipliers being swapped
  • Fix Xilonen sheet logic
    • Geo source now properly only activates if there are < 3 PHEC teammates (tested in-game)
    • Change C2 to only be active if the source is converted
    • Update certain conditionals/fields to only appear when relevant
    • Allow Geo res shred to be active even without activating the other source samples, while in NS state, and while C2+
    • Add elemental coloring to the C2 buffs for clarity
    • image

Issue or discord link

Testing/validation

Before/After of spacing fix (Duration, CD and Energy Cost have extra padding relative to the other fields)
image

Sethos CA level 1 compared to hakushin
image
image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 requested a review from frzyc October 12, 2024 17:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024 •
edited
Loading

[frontend] [Sat Oct 12 17:29:40 UTC 2024] - Deployed 5e58d59 to https://genshin-optimizer-prs.github.io/pr/2493/frontend (Takes 3-5 minutes after this completes to be available)

[Sat Oct 12 19:15:33 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 merged commit ccddec8 into master Oct 12, 2024
8 checks passed
@nguyentvan7 nguyentvan7 deleted the van/go/fixes branch October 12, 2024 19:14
macerator-yaro pushed a commit to macerator-yaro/genshin-optimizer that referenced this pull request Oct 29, 2024
@nguyentvan7 @macerator-yaro
Fix various issues (frzyc#2493)
eb9f26a 
* Fix Scroll duration

* Fix HMR

* Fix Clorinde duration

* Fix inconsistent spacing

* Fix Sethos multipliers

* Fix Xilonen sheet logic

* Fix error
macerator-yaro pushed a commit to macerator-yaro/genshin-optimizer that referenced this pull request Oct 29, 2024
@nguyentvan7 @macerator-yaro
Fix various issues (frzyc#2493)
3eccbef 
* Fix Scroll duration

* Fix HMR

* Fix Clorinde duration

* Fix inconsistent spacing

* Fix Sethos multipliers

* Fix Xilonen sheet logic

* Fix error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frzyc frzyc frzyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Xilonen Geo Shred behavior is incorrect Sethos CA/Plunge multipliers are swapped
2 participants
@nguyentvan7 @frzyc