-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix archive asset urls #2479
Merged
Merged
fix archive asset urls #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Van Nguyen <[email protected]>
Co-authored-by: Van Nguyen <[email protected]>
Co-authored-by: Van Nguyen <[email protected]>
nguyentvan7
approved these changes
Oct 4, 2024
macerator-yaro
pushed a commit
to macerator-yaro/genshin-optimizer
that referenced
this pull request
Oct 29, 2024
* add debug command * Update apps/somnia/src/commands/debug.ts Co-authored-by: Van Nguyen <[email protected]> * add links to github * fix hyperlink * Update debug.ts Co-authored-by: Van Nguyen <[email protected]> * Update debug.ts Co-authored-by: Van Nguyen <[email protected]> * user installed archive command * Update events.ts * fix asset url * fix formatting --------- Co-authored-by: Van Nguyen <[email protected]>
macerator-yaro
pushed a commit
to macerator-yaro/genshin-optimizer
that referenced
this pull request
Oct 29, 2024
* add debug command * Update apps/somnia/src/commands/debug.ts Co-authored-by: Van Nguyen <[email protected]> * add links to github * fix hyperlink * Update debug.ts Co-authored-by: Van Nguyen <[email protected]> * Update debug.ts Co-authored-by: Van Nguyen <[email protected]> * user installed archive command * Update events.ts * fix asset url * fix formatting --------- Co-authored-by: Van Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
fix archive asset urls
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.