Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pando conditional UI #2422

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Pando conditional UI #2422

merged 5 commits into from
Aug 31, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Aug 29, 2024

Describe your changes

Getting conditional to show up on RuanMei UI in Team.
Only boolean conditional is shown, should be able to expand to other types.

TODO:

  • debug why the value from db is not being passed through Calc to UI (using db with conditonals enabled)
  • make conditional toggleable (pass value to db)
  • [already done] modify TeamCalcProvider to get db conditional value and pass to Calc

Issue or discord link

Testing/validation

image

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Aug 29, 2024

[sr-frontend] [Thu Aug 29 03:04:31 UTC 2024] - Deployed cc39cb9 to https://genshin-optimizer-prs.github.io/pr/2422/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Thu Aug 29 14:15:46 UTC 2024] - Deployed 51231eb to https://genshin-optimizer-prs.github.io/pr/2422/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 30 03:21:47 UTC 2024] - Deployed b7a5192 to https://genshin-optimizer-prs.github.io/pr/2422/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 30 03:23:48 UTC 2024] - Deployed b7a5192 to https://genshin-optimizer-prs.github.io/pr/2422/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Aug 30 03:29:48 UTC 2024] - Deployed eb2f14b to https://genshin-optimizer-prs.github.io/pr/2422/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 30 03:30:25 UTC 2024] - Deployed eb2f14b to https://genshin-optimizer-prs.github.io/pr/2422/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Aug 31 02:54:05 UTC 2024] - Deployed 71d8710 to https://genshin-optimizer-prs.github.io/pr/2422/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Aug 31 02:54:20 UTC 2024] - Deployed 71d8710 to https://genshin-optimizer-prs.github.io/pr/2422/frontend (Takes 3-5 minutes after this completes to be available)

[Sat Aug 31 05:48:29 UTC 2024] - Deleted deployment

@frzyc frzyc marked this pull request as ready for review August 30, 2024 03:19
@frzyc frzyc requested a review from nguyentvan7 August 30, 2024 03:19
@frzyc frzyc changed the title rudimentary conditional UI Pando conditional UI Aug 30, 2024
@frzyc frzyc added the Pando To be implemented as a feature requirement for Pando label Aug 30, 2024
nguyentvan7
nguyentvan7 previously approved these changes Aug 30, 2024
libs/pando/ui-sheet/src/components/DocumentDisplay.tsx Outdated Show resolved Hide resolved
@frzyc frzyc merged commit 88bb289 into master Aug 31, 2024
9 checks passed
@frzyc frzyc deleted the pando_conditional_ui branch August 31, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pando To be implemented as a feature requirement for Pando
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SRO] Add simple conditional UI based on tags
2 participants