Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when optimizing with Scroll set #2413

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

nguyentvan7
Copy link
Collaborator

Describe your changes

  • Fix crash caused by putting the artifact set count check in the innermost layer of the nodes instead of outermost
  • Also simplified some of the logic

Issue or discord link

Testing/validation

Create a TC build with Scroll 4p and optimize
Don't crash

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 added bug Something isn't working fix ASAP Needs to be fixed as soon as possible labels Aug 28, 2024
@nguyentvan7 nguyentvan7 requested a review from frzyc August 28, 2024 22:37
frzyc
frzyc previously approved these changes Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

[frontend] [Wed Aug 28 22:40:23 UTC 2024] - Deployed 92cd685 to https://genshin-optimizer-prs.github.io/pr/2413/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Aug 28 22:40:56 UTC 2024] - Deployed 92cd685 to https://genshin-optimizer-prs.github.io/pr/2413/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Aug 28 22:51:24 UTC 2024] - Deployed 7adaca7 to https://genshin-optimizer-prs.github.io/pr/2413/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Aug 28 22:56:28 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 merged commit 627dea4 into master Aug 28, 2024
8 checks passed
@nguyentvan7 nguyentvan7 deleted the van/go/scrollFix branch August 28, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix ASAP Needs to be fixed as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants