Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal ui-sheets for SRO #2392

Merged
merged 1 commit into from
Aug 24, 2024
Merged

minimal ui-sheets for SRO #2392

merged 1 commit into from
Aug 24, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Aug 24, 2024

Describe your changes

Create a minimal UI sheet for RuanMei in ui-sheet lib for SRO

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc added the SRO For Star Rail Optimizer label Aug 24, 2024
@frzyc frzyc requested a review from nguyentvan7 August 24, 2024 21:24
Copy link
Contributor

github-actions bot commented Aug 24, 2024

[sr-frontend] [Sat Aug 24 21:27:43 UTC 2024] - Deployed 454fd19 to https://genshin-optimizer-prs.github.io/pr/2392/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Aug 24 21:28:07 UTC 2024] - Deployed 454fd19 to https://genshin-optimizer-prs.github.io/pr/2392/frontend (Takes 3-5 minutes after this completes to be available)

[Sat Aug 24 23:01:15 UTC 2024] - Deleted deployment

@frzyc frzyc merged commit a609eea into master Aug 24, 2024
13 checks passed
@frzyc frzyc deleted the sr_ui_sheet branch August 24, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SRO For Star Rail Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants