Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditionals #2386

Merged
merged 4 commits into from
Aug 24, 2024
Merged

Update conditionals #2386

merged 4 commits into from
Aug 24, 2024

Conversation

lantua
Copy link
Collaborator

@lantua lantua commented Aug 24, 2024

Describe your changes

  • Add missing name: tag erasure to improve caching
  • Use max accumulator for conditionals to make them idempotent, writing the same conditional values multiple times yield the same result. (writing different values will use the largest one.)
  • Remove src:all and dst:all. calcResult.conds still use all when tag categories are not present. all keys will be converted to/from appropriately.

Issue or discord link

https://discord.com/channels/785153694478893126/1189329506842984570/1276714898440720395

Testing/validation

Same unit tests

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@lantua lantua requested a review from nguyentvan7 August 24, 2024 02:34
Copy link
Contributor

github-actions bot commented Aug 24, 2024

[sr-frontend] [Sat Aug 24 02:37:10 UTC 2024] - Deployed 7ff66e2 to https://genshin-optimizer-prs.github.io/pr/2386/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Aug 24 05:34:44 UTC 2024] - Deployed 6a69cf5 to https://genshin-optimizer-prs.github.io/pr/2386/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Aug 24 05:35:08 UTC 2024] - Deployed 6a69cf5 to https://genshin-optimizer-prs.github.io/pr/2386/frontend (Takes 3-5 minutes after this completes to be available)

[Sat Aug 24 05:38:37 UTC 2024] - Deleted deployment

- Remove `dst:all`
@lantua lantua merged commit 76fd28d into master Aug 24, 2024
9 checks passed
@lantua lantua deleted the cond branch August 24, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants