Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document to pando and gi-formula #2376

Merged
merged 14 commits into from
Aug 25, 2024
Merged

Add document to pando and gi-formula #2376

merged 14 commits into from
Aug 25, 2024

Conversation

lantua
Copy link
Collaborator

@lantua lantua commented Aug 12, 2024

Describe your changes

Add documents

Issue or discord link

n/a

Testing/validation

n/a

Checklist before requesting a review (leave this PR as a draft if any part of this list is not done.)

  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Aug 12, 2024

[sr-frontend] [Mon Aug 12 18:29:46 UTC 2024] - Deployed 0aa6f78 to https://genshin-optimizer-prs.github.io/pr/2376/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Aug 12 18:30:12 UTC 2024] - Deployed a1c3736 to https://genshin-optimizer-prs.github.io/pr/2376/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Aug 12 20:16:54 UTC 2024] - Deployed 6447f2e to https://genshin-optimizer-prs.github.io/pr/2376/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Aug 14 15:15:18 UTC 2024] - Deployed 4427999 to https://genshin-optimizer-prs.github.io/pr/2376/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 23 19:27:31 UTC 2024] - Deployed 1f0e614 to https://genshin-optimizer-prs.github.io/pr/2376/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 23 20:29:29 UTC 2024] - Deployed 56555f8 to https://genshin-optimizer-prs.github.io/pr/2376/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Sun Aug 25 22:54:40 UTC 2024] - Deleted deployment

libs/gi/formula/doc/tag_arch.md Outdated Show resolved Hide resolved

- Read-side `et:` specifies whether the query computes the current character stat (`et:self`), team-wide stat (`et:team`), the stat of the buff target (`et:target`), or the common enemy stat (`et:enemy`).
- Write-side `et:` specifies whether the entry applies only to the current character (`et:selfBuff`), the entire team (`et:teamBuff`), other members (`et:notSelfBuff`), or the enemy (`et:enemy`).
- Read-side `sheet:` speficies the sheets to include in gathering, whether to gather all sheets from all members (`sheet:agg`), only character sheets of the current member (`sheet:iso`), or common listing outside of any specific sheets (`static`).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move that big table in tag.ts here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown doesn't seem to have very good table support, esp. on merging table cells.

@lantua lantua requested a review from nguyentvan7 August 23, 2024 20:28
@lantua lantua merged commit f0db5d9 into master Aug 25, 2024
8 checks passed
@lantua lantua deleted the pandoc branch August 25, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants