Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of SR stuff; add Ruan Mei data sheet #2372

Merged
merged 23 commits into from
Aug 12, 2024
Merged

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Aug 9, 2024

Describe your changes

  • Grab AvatarBreakDamage (break damage level multiplier) from datamine
  • Add util for bonusAbility params and break damage
  • Add enemy setup for break damage
  • Add Ruan Mei data sheet
  • Fix relic main stat value in calculator
  • Fix stat boosts reading from the incorrect value
  • Fix calculator using wrong member format
  • Add temporary view to see all formulas for a given char
  • Add support for conditional data in calculator
  • Divide components out of Context/Provider to fix HMR
  • Fix console warning
  • Fix March7th The Hunt's name
  • [Lantua] Combine debug calculators

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Aug 9, 2024

[sr-frontend] [Fri Aug 9 05:50:24 UTC 2024] - Deployed a57125e to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 9 06:54:32 UTC 2024] - Deployed 67334f4 to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 9 14:09:33 UTC 2024] - Deployed f62b6e6 to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 9 16:41:26 UTC 2024] - Deployed a2fe208 to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 9 17:02:59 UTC 2024] - Deployed 015bd90 to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 9 17:06:13 UTC 2024] - Deployed ee4947c to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 9 22:42:50 UTC 2024] - Deployed 2b6cf4e to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Aug 11 20:43:55 UTC 2024] - Deployed 7cefc2c to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Aug 11 20:45:04 UTC 2024] - Deployed 370bf1a to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Aug 11 23:34:38 UTC 2024] - Deployed f138891 to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Aug 12 15:32:30 UTC 2024] - Deployed 308e06d to https://genshin-optimizer-prs.github.io/pr/2372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Mon Aug 12 15:43:04 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 changed the title Add break and bonusAbility utils; add Ruan Mei data sheet Fix a bunch of SR stuff; add Ruan Mei data sheet Aug 9, 2024
@nguyentvan7 nguyentvan7 requested a review from lantua August 11, 2024 23:32
lantua
lantua previously approved these changes Aug 11, 2024
Copy link
Collaborator

@lantua lantua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuffs, but otherwise lgtm

apps/sr-frontend/src/app/PageHome.tsx Show resolved Hide resolved
libs/gi/formula/src/util.ts Outdated Show resolved Hide resolved
libs/sr/formula/src/data/char/RuanMei.ts Outdated Show resolved Hide resolved
libs/sr/formula/src/data/char/RuanMei.ts Outdated Show resolved Hide resolved
libs/sr/formula/src/data/char/RuanMei.ts Outdated Show resolved Hide resolved
libs/sr/formula/src/data/char/RuanMei.ts Show resolved Hide resolved
libs/sr/formula/src/data/char/RuanMei.ts Outdated Show resolved Hide resolved
libs/sr/formula/src/data/util/sheet.ts Outdated Show resolved Hide resolved
libs/sr/formula/src/data/char/util.ts Outdated Show resolved Hide resolved
libs/sr/formula/src/util.ts Outdated Show resolved Hide resolved
@nguyentvan7 nguyentvan7 merged commit 37cf0f5 into master Aug 12, 2024
8 checks passed
@nguyentvan7 nguyentvan7 deleted the van/ruanmei branch August 12, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants