Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Translate and Theme to common lib #2371

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Conversation

tiffanynwyeung
Copy link
Collaborator

@tiffanynwyeung tiffanynwyeung commented Aug 8, 2024

Describe your changes

  • Move Translate logic into new generic TranslateBase living in common/ui, with Translate now acting as a wrapper function to call it in both GO and SRO
  • Remove TransWrapper component (nothing uses it at all across GO/SRO currently)
  • Move all shared theme styles to common/ui, renaming brand[GO|SRO]500 to brand500
  • Generate new SRO theme library (necessary as SRO/Translate depends on theme colors)
  • Remove extra Theme file from sr-frontend and call theme lib version instead
  • Add new yarn cache packages for macOS

Note: current SRO elemental colors are taken from the HSR fandom wiki as placeholders until official colors are established

Issue or discord link

Testing/validation

Run nx serve frontend and check that translations in different languages are rendering correctly. Some good pages are GO artifact card UI and character talent sheets.

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@tiffanynwyeung tiffanynwyeung requested a review from frzyc August 8, 2024 06:17
Copy link
Contributor

github-actions bot commented Aug 8, 2024

[sr-frontend] [Thu Aug 8 06:19:47 UTC 2024] - Deployed 4366da5 to https://genshin-optimizer-prs.github.io/pr/2371/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Aug 8 06:20:13 UTC 2024] - Deployed 4366da5 to https://genshin-optimizer-prs.github.io/pr/2371/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Thu Aug 8 06:30:16 UTC 2024] - Deployed 66b9951 to https://genshin-optimizer-prs.github.io/pr/2371/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Aug 8 06:30:56 UTC 2024] - Deployed 66b9951 to https://genshin-optimizer-prs.github.io/pr/2371/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Aug 9 07:18:08 UTC 2024] - Deployed 10626ce to https://genshin-optimizer-prs.github.io/pr/2371/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Aug 9 07:18:14 UTC 2024] - Deployed 10626ce to https://genshin-optimizer-prs.github.io/pr/2371/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Aug 12 20:46:45 UTC 2024] - Deployed 7c0c804 to https://genshin-optimizer-prs.github.io/pr/2371/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Aug 12 20:47:23 UTC 2024] - Deployed 7c0c804 to https://genshin-optimizer-prs.github.io/pr/2371/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Aug 13 02:51:28 UTC 2024] - Deleted deployment

frzyc
frzyc previously requested changes Aug 8, 2024
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

libs/sr/theme/src/Theme.tsx Outdated Show resolved Hide resolved
libs/sr/theme/src/Theme.tsx Outdated Show resolved Hide resolved
libs/common/ui/src/components/Translate.tsx Outdated Show resolved Hide resolved
@tiffanynwyeung tiffanynwyeung changed the title Port Translate component to common lib + add SRO theme Port Translate and Theme to common lib Aug 9, 2024
@tiffanynwyeung tiffanynwyeung requested a review from frzyc August 9, 2024 07:23
@tiffanynwyeung tiffanynwyeung requested review from nguyentvan7 and removed request for frzyc August 12, 2024 20:44
@nguyentvan7 nguyentvan7 merged commit 64cbb95 into master Aug 13, 2024
9 checks passed
@nguyentvan7 nguyentvan7 deleted the common/port-translate branch August 13, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants