-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Translate and Theme to common lib #2371
Conversation
[sr-frontend] [Thu Aug 8 06:19:47 UTC 2024] - Deployed 4366da5 to https://genshin-optimizer-prs.github.io/pr/2371/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Thu Aug 8 06:20:13 UTC 2024] - Deployed 4366da5 to https://genshin-optimizer-prs.github.io/pr/2371/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Thu Aug 8 06:30:16 UTC 2024] - Deployed 66b9951 to https://genshin-optimizer-prs.github.io/pr/2371/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Thu Aug 8 06:30:56 UTC 2024] - Deployed 66b9951 to https://genshin-optimizer-prs.github.io/pr/2371/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Aug 9 07:18:08 UTC 2024] - Deployed 10626ce to https://genshin-optimizer-prs.github.io/pr/2371/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Fri Aug 9 07:18:14 UTC 2024] - Deployed 10626ce to https://genshin-optimizer-prs.github.io/pr/2371/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Mon Aug 12 20:46:45 UTC 2024] - Deployed 7c0c804 to https://genshin-optimizer-prs.github.io/pr/2371/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Mon Aug 12 20:47:23 UTC 2024] - Deployed 7c0c804 to https://genshin-optimizer-prs.github.io/pr/2371/frontend (Takes 3-5 minutes after this completes to be available) [Tue Aug 13 02:51:28 UTC 2024] - Deleted deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes
- adjust references to theme in GO and SRO frontends, and dedupe as necessary - rename brand[GO|SRO]500 to brand500 - remove extra theme file in SRO frontend
ae1ffcb
to
ea7cf45
Compare
Describe your changes
Translate
logic into new genericTranslateBase
living incommon/ui
, withTranslate
now acting as a wrapper function to call it in both GO and SROTransWrapper
component (nothing uses it at all across GO/SRO currently)common/ui
, renamingbrand[GO|SRO]500
tobrand500
Translate
depends on theme colors)Theme
file fromsr-frontend
and calltheme
lib version insteadNote: current SRO elemental colors are taken from the HSR fandom wiki as placeholders until official colors are established
Issue or discord link
Testing/validation
Run
nx serve frontend
and check that translations in different languages are rendering correctly. Some good pages are GO artifact card UI and character talent sheets.Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.