Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character Material generation #2360

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

priolette
Copy link
Contributor

Describe your changes

Added character ascension and talent material generation

Issue or discord link

Testing/validation

Check the allCharacterMat_gen.json file

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 August 5, 2024 07:42
Copy link
Contributor

github-actions bot commented Aug 5, 2024

[sr-frontend] [Mon Aug 5 07:44:59 UTC 2024] - Deployed ade3f1b to https://genshin-optimizer-prs.github.io/pr/2360/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Aug 5 07:45:19 UTC 2024] - Deployed ade3f1b to https://genshin-optimizer-prs.github.io/pr/2360/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Aug 5 20:38:24 UTC 2024] - Deployed 453efd7 to https://genshin-optimizer-prs.github.io/pr/2360/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Aug 5 20:38:39 UTC 2024] - Deployed 453efd7 to https://genshin-optimizer-prs.github.io/pr/2360/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Aug 6 17:08:24 UTC 2024] - Deleted deployment

Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some questions/style comment

libs/gi/mats/tsconfig.json Outdated Show resolved Hide resolved
libs/gi/dm/src/dm/character/ProudSkillExcelConfigData.ts Outdated Show resolved Hide resolved
@priolette priolette requested a review from nguyentvan7 August 5, 2024 20:40
@nguyentvan7 nguyentvan7 merged commit a46f24e into frzyc:master Aug 6, 2024
9 checks passed
@priolette priolette deleted the material-gen branch August 6, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants