Fix go-next typecheck and add build CI #2318
Conversation
|
[sr-frontend] [Tue Jul 16 12:26:26 UTC 2024] - Deployed c95bfc8 to https://genshin-optimizer-prs.github.io/pr/2318/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue Jul 16 12:26:47 UTC 2024] - Deployed c95bfc8 to https://genshin-optimizer-prs.github.io/pr/2318/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Jul 17 09:59:14 UTC 2024] - Deployed a8e2eb2 to https://genshin-optimizer-prs.github.io/pr/2318/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Jul 17 09:59:23 UTC 2024] - Deployed a8e2eb2 to https://genshin-optimizer-prs.github.io/pr/2318/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sat Jul 20 11:47:27 UTC 2024] - Deployed 0d9212c to https://genshin-optimizer-prs.github.io/pr/2318/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sat Jul 20 11:47:47 UTC 2024] - Deployed 0d9212c to https://genshin-optimizer-prs.github.io/pr/2318/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sat Jul 20 12:24:24 UTC 2024] - Deployed e1ec998 to https://genshin-optimizer-prs.github.io/pr/2318/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sat Jul 20 12:24:38 UTC 2024] - Deployed e1ec998 to https://genshin-optimizer-prs.github.io/pr/2318/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sat Jul 20 12:47:30 UTC 2024] - Deployed b0137f4 to https://genshin-optimizer-prs.github.io/pr/2318/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sat Jul 20 12:47:41 UTC 2024] - Deployed b0137f4 to https://genshin-optimizer-prs.github.io/pr/2318/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sat Jul 20 14:30:21 UTC 2024] - Deployed 9403278 to https://genshin-optimizer-prs.github.io/pr/2318/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sat Jul 20 14:30:50 UTC 2024] - Deployed 9403278 to https://genshin-optimizer-prs.github.io/pr/2318/frontend (Takes 3-5 minutes after this completes to be available) [Sat Jul 20 16:10:53 UTC 2024] - Deleted deployment |
frzyc
changed the title
| - 'apps/sr-frontend-e2e/**' | ||
| - 'libs/gi/frontend-gql/**' | ||
| - 'libs/gi/prisma-schema/**' | ||
| - 'libs/gi/ui-next/**' |
There was a problem hiding this comment.
its from the deprecated stack,
| yarn run nx run ${{inputs.frontend_name}}:build:production | ||
| - name: Build gi-frontend | ||
| if: inputs.frontend_name == 'gi-frontend' | ||
| run: yarn nx run gi-frontend:next:build |
There was a problem hiding this comment.
Cant you just override build in gi-frontend project.json to call next:build?
There was a problem hiding this comment.
i had trouble getting the build:production to work, this is mostly a bandaid anyways, will likely come back to this once we have go-next deployments
Describe your changes
Trying to address the fact that the go-next project has somewhat differing tsconfig, which makes existing libs unbuildable.
https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/69389to address the build issue:string, but in nextjs, its imported asStaticImageData. This makes type ducking quite weird.build go-nextto the CI to ensure further buildability once type issues are addressed.Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.