Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove melee infusion button from teams UI, move hitmode buttons #1758

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Mar 16, 2024

Describe your changes

Removes melee infusion dropdown, and move hitmode buttons to clean up team UI header

Issue or discord link

Testing/validation

Talent
image
TC
image
Overview
image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 March 16, 2024 10:28
@frzyc frzyc self-assigned this Mar 16, 2024
Copy link
Contributor

github-actions bot commented Mar 16, 2024

[frontend] [Sat Mar 16 10:32:50 UTC 2024] - Deployed 9faf0a2 to https://genshin-optimizer-prs.github.io/pr/1758/frontend (Takes 3-5 minutes after this completes to be available)

[Sat Mar 16 21:29:44 UTC 2024] - Deleted deployment

Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner, good change

@frzyc frzyc merged commit 533c5ac into master Mar 16, 2024
5 checks passed
@frzyc frzyc deleted the 1646 branch March 16, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Hit mode / Reaction toggles from the top of the page Remove infusion drop down
2 participants