Fix incorrect usage of main stat display value for optimization #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[frontend] [Sat Mar 16 02:48:19 UTC 2024] - Deployed 49de2c7 to https://genshin-optimizer-prs.github.io/pr/1745/frontend (Takes 3-5 minutes after this completes to be available) [Sat Mar 16 07:22:49 UTC 2024] - Deleted deployment |
frzyc
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Change opt and up-opt to use the raw mainstat value, rather than the display value (which rounded EM and caused minor calculation errors.
This was harder to spot because we still recalculate and display the values to the user using the correctly un-rounded EM. We were just optimizing with the wrong value. So in this case, this caused the 2 builds to sort incorrectly, revealing the issue.
TC opt doesn't look like it calls this function
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.