-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active build/compare to be stored per team #1724
Conversation
[frontend] [Thu Mar 14 19:27:55 UTC 2024] - Deployed 2ee82fe to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Thu Mar 14 20:07:31 UTC 2024] - Deployed 6318f1f to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Thu Mar 14 20:43:52 UTC 2024] - Deployed 1fed4e9 to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Thu Mar 14 22:57:39 UTC 2024] - Deployed d3bb59f to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Mar 15 02:07:29 UTC 2024] - Deployed d194959 to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Mar 15 02:17:22 UTC 2024] - Deployed 5d11d59 to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Mar 15 03:04:32 UTC 2024] - Deployed a00122f to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available) [Fri Mar 15 07:44:10 UTC 2024] - Deleted deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed the code and lightly tested func, lgtm
Describe your changes
Since loadouts are now sharable across different teams, the data associated with "which build is active" should not be stored on the loadout, but rather on the team. This allow you to have a loadout that generates a specific build at different ER breakpoints, and have different ER builds active on different teams.
Note: Database migration to v25
Issue or discord link
Testing/validation
Showing a duplicated build (that shares loadout) with different "active" builds
Build dropdown in team setting
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.