Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active build/compare to be stored per team #1724

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Active build/compare to be stored per team #1724

merged 7 commits into from
Mar 15, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Mar 14, 2024

Describe your changes

Since loadouts are now sharable across different teams, the data associated with "which build is active" should not be stored on the loadout, but rather on the team. This allow you to have a loadout that generates a specific build at different ER breakpoints, and have different ER builds active on different teams.

Note: Database migration to v25

Issue or discord link

Testing/validation

Showing a duplicated build (that shares loadout) with different "active" builds
image
image
Build dropdown in team setting
image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Mar 14, 2024

[frontend] [Thu Mar 14 19:27:55 UTC 2024] - Deployed 2ee82fe to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Mar 14 20:07:31 UTC 2024] - Deployed 6318f1f to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Mar 14 20:43:52 UTC 2024] - Deployed 1fed4e9 to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Mar 14 22:57:39 UTC 2024] - Deployed d3bb59f to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Mar 15 02:07:29 UTC 2024] - Deployed d194959 to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Mar 15 02:17:22 UTC 2024] - Deployed 5d11d59 to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Mar 15 03:04:32 UTC 2024] - Deployed a00122f to https://genshin-optimizer-prs.github.io/pr/1724/frontend (Takes 3-5 minutes after this completes to be available)

[Fri Mar 15 07:44:10 UTC 2024] - Deleted deployment

@frzyc frzyc requested a review from nguyentvan7 March 14, 2024 20:04
@frzyc frzyc self-assigned this Mar 14, 2024
nguyentvan7
nguyentvan7 previously approved these changes Mar 15, 2024
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed the code and lightly tested func, lgtm

@frzyc frzyc requested a review from nguyentvan7 March 15, 2024 05:05
@frzyc frzyc merged commit 643fe46 into master Mar 15, 2024
5 checks passed
@frzyc frzyc deleted the build_per_team branch March 15, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hover tooltip to show build for loadouts
2 participants