Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EidolonKey to contain 0 #1506

Merged
merged 7 commits into from
Feb 17, 2024
Merged

Fix EidolonKey to contain 0 #1506

merged 7 commits into from
Feb 17, 2024

Conversation

nguyentvan7
Copy link
Collaborator

Describe your changes

  • Fix EidolonKey to contain 0
  • Update characterData to use a DM-only key that is 1-6

Issue or discord link

Testing/validation

  • Regenerated sr-stats and no changes/crashes, as expected

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 requested a review from frzyc February 16, 2024 23:51
Copy link
Contributor

github-actions bot commented Feb 16, 2024

[sr-frontend] [Fri Feb 16 23:53:31 UTC 2024] - Building version 8ca2a4d

[sr-frontend] [Sat Feb 17 00:10:11 UTC 2024] - Building version 89959f5

[sr-frontend] [Sat Feb 17 00:15:35 UTC 2024] - Building version 0c1f0cd

[sr-frontend] [Sat Feb 17 00:33:53 UTC 2024] - Building version 4806894

[sr-frontend] [Sat Feb 17 00:33:55 UTC 2024] - Building version 5e06dad

[sr-frontend] [Sat Feb 17 00:35:23 UTC 2024] - Deployed 5e06dad to https://genshin-optimizer-prs.github.io/pr/1506/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Feb 17 01:43:36 UTC 2024] - Building version 5b52ead

[sr-frontend] [Sat Feb 17 01:45:04 UTC 2024] - Deployed 5b52ead to https://genshin-optimizer-prs.github.io/pr/1506/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Sat Feb 17 02:18:09 UTC 2024] - Deleted deployment

Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant XKCD https://xkcd.com/163/

@nguyentvan7 nguyentvan7 merged commit 59fcdc9 into master Feb 17, 2024
4 checks passed
@nguyentvan7 nguyentvan7 deleted the van/sro/fixEidKey branch February 17, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants