Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SR 2.0 information, de-extrapolate values #1487

Merged
merged 4 commits into from
Feb 17, 2024
Merged

Conversation

nguyentvan7
Copy link
Collaborator

Describe your changes

  • Add 2.0 Star Rail data
  • Update Star Rail datamine commit
  • Add boilerplate sheets for 2.0 data
  • Remove usage of extrapolate float, as datamine values are now precise

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Feb 6, 2024

[sr-frontend] [Tue Feb 6 05:56:31 UTC 2024] - Building version 9f52f5f

[sr-frontend] [Tue Feb 6 05:58:01 UTC 2024] - Deployed 9f52f5f to https://genshin-optimizer-prs.github.io/pr/1487/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Sat Feb 17 02:18:33 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 requested a review from frzyc February 17, 2024 00:15
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create issue to track some number inconsistency

@nguyentvan7 nguyentvan7 merged commit b25422a into master Feb 17, 2024
4 checks passed
@nguyentvan7 nguyentvan7 deleted the van/sro/2.0 branch February 17, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants