Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sheet generation and add missing items for sr-formula #1453

Merged
merged 8 commits into from
Jan 24, 2024

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Jan 24, 2024

Describe your changes

  • Add sheet generator (copied from gi-formula; modified templates)
  • Add meta export (copied from gi-formula)
  • Add missing char/relics/lcs
  • Generate all missing sheets
  • Fix superimpose array to have -1 as first element for proper indexing

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Jan 24, 2024

[sr-frontend] [Wed Jan 24 06:22:52 UTC 2024] - Building version d076099

[sr-frontend] [Wed Jan 24 06:41:35 UTC 2024] - Building version 6aa7b48

[sr-frontend] [Wed Jan 24 06:43:01 UTC 2024] - Deployed 6aa7b48 to https://genshin-optimizer-prs.github.io/pr/1453/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Wed Jan 24 14:43:44 UTC 2024] - Deleted deployment

frzyc
frzyc previously approved these changes Jan 24, 2024
@nguyentvan7 nguyentvan7 merged commit 461cdc0 into master Jan 24, 2024
4 checks passed
@nguyentvan7 nguyentvan7 deleted the van/sro/sheetGenerator branch January 24, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants