Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't append subs in copyFromEquipped #1450

Closed
wants to merge 1 commit into from

Conversation

eeeqeee
Copy link
Collaborator

@eeeqeee eeeqeee commented Jan 24, 2024

Describe your changes

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Jan 24, 2024

[frontend] [Wed Jan 24 01:51:51 UTC 2024] - Building version a7fc37b

[sr-frontend] [Wed Jan 24 01:51:53 UTC 2024] - Building version a7fc37b

[sr-frontend] [Wed Jan 24 01:53:21 UTC 2024] - Deployed a7fc37b to https://genshin-optimizer-prs.github.io/pr/1450/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Jan 24 01:53:26 UTC 2024] - Deployed a7fc37b to https://genshin-optimizer-prs.github.io/pr/1450/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Jan 24 02:02:58 UTC 2024] - Deleted deployment

@eeeqeee eeeqeee requested a review from frzyc January 24, 2024 01:52
@eeeqeee eeeqeee closed this Jan 24, 2024
@eeeqeee eeeqeee deleted the fix-copyFromEquipped-append branch February 25, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant