Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overview tab layout #1448

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix overview tab layout #1448

merged 1 commit into from
Jan 24, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Jan 23, 2024

Describe your changes

image

Validation

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 January 23, 2024 20:22
Copy link
Contributor

github-actions bot commented Jan 23, 2024

[sr-frontend] [Tue Jan 23 20:23:17 UTC 2024] - Building version a35a918

[sr-frontend] [Tue Jan 23 20:24:39 UTC 2024] - Deployed a35a918 to https://genshin-optimizer-prs.github.io/pr/1448/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 23 20:24:48 UTC 2024] - Building version a35a918

[frontend] [Tue Jan 23 20:26:47 UTC 2024] - Deployed a35a918 to https://genshin-optimizer-prs.github.io/pr/1448/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Jan 24 00:29:57 UTC 2024] - Deleted deployment

Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you even notice this lol

@frzyc frzyc merged commit 0665974 into master Jan 24, 2024
5 checks passed
@frzyc frzyc deleted the overview_fix branch January 24, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants