prevent canceling from breaking future opt runs #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[frontend] [Sun Jan 21 17:27:42 UTC 2024] - Building version 3c4efb7 [sr-frontend] [Sun Jan 21 17:27:54 UTC 2024] - Building version 3c4efb7 [sr-frontend] [Sun Jan 21 17:29:21 UTC 2024] - Deployed 3c4efb7 to https://genshin-optimizer-prs.github.io/pr/1444/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Jan 21 17:29:39 UTC 2024] - Deployed 3c4efb7 to https://genshin-optimizer-prs.github.io/pr/1444/frontend (Takes 3-5 minutes after this completes to be available) [Sun Jan 21 18:55:05 UTC 2024] - Deleted deployment |
frzyc
approved these changes
Jan 21, 2024
frzyc
added a commit
that referenced
this pull request
Jan 24, 2024
* wip: tc-opt * fixes * add comments * fix hysteresis * eslint fixes + touchups * remove max+offset from display * Fix apply not working & set max default to 30 subs * wtf is teamData i think it should call `uiDataForTeam` through - teamData - useTeamData - getTeamDataCalc - uiDataForTeam * cleanup max+offset * add UI to mass edit substat rolls/max * fix bugs * fix merge * guard printing * fmt * extract to function * hardcode answer if more distributedSubs than max * add comment and fold ignored subs * missed rename * add comments * minor fixes * minor updates & fixes * minor fixes * forgot to assign the last substat * minor refactoring * add rarity + better max * update roll calc * update input * add kqms button * prevent all editors to trigger on 1st render * avoid using `any` in upOpt.ts * format * switch to `shouldShowDevComponents` * update initializer function for charTC * add 2 rolls to kqms * update default/reset rolls for charTC * add dialogs * use KQMS * add gcsim snippet * gcsim has no comma * use raw value * refinement * add `minSubstats` and `scalesWith` * change from `minSubstats` to `minTotal` * cap * Revert "change from `minSubstats` to `minTotal`" This reverts commit 269cd95. * Revert "add `minSubstats` and `scalesWith`" This reverts commit b48b513. * minor update * util * Tc opt 2 (#1423) * add `minSubstats` and `scalesWith` * change from `minSubstats` to `minTotal` * fix mintotal * Tc opt 2 with feasibility check (#1424) * feasibility check in solver * fix distributed - other * fix other roll calculation * fix getMinSubLines * worker hookup and UI disable when solving * add constraints * fix double counting issue * add unit test * add QoL * fix lint * translation + bugfix * update constraintCard * address comments * prevent canceling from breaking future opt runs (#1444) * fix quotes * addresss comments * addresss comments * format * fix merge issue --------- Co-authored-by: eeeqeee <> Co-authored-by: frzyc <[email protected]> Co-authored-by: Van Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format + lint.nx format writeto resolve them automatically.