Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secondary damageType #1443

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Add secondary damageType #1443

merged 3 commits into from
Jan 21, 2024

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Jan 20, 2024

Describe your changes

  • Add support for a secondary damage type in sr-formula, for abilities that do 2 different types of damage
  • Add util functions to support sheet creation of those abilities

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Jan 20, 2024

[sr-frontend] [Sat Jan 20 06:07:25 UTC 2024] - Building version e92977e

[sr-frontend] [Sat Jan 20 06:08:46 UTC 2024] - Deployed e92977e to https://genshin-optimizer-prs.github.io/pr/1443/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Jan 21 17:36:17 UTC 2024] - Building version fdc9d5d

[sr-frontend] [Sun Jan 21 17:37:50 UTC 2024] - Deployed fdc9d5d to https://genshin-optimizer-prs.github.io/pr/1443/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Jan 21 17:43:03 UTC 2024] - Building version 35dda9f

[sr-frontend] [Sun Jan 21 17:44:25 UTC 2024] - Deployed 35dda9f to https://genshin-optimizer-prs.github.io/pr/1443/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Sun Jan 21 17:50:09 UTC 2024] - Deleted deployment

libs/sr-formula/src/data/util/read.ts Outdated Show resolved Hide resolved
libs/sr-formula/src/data/util/read.ts Outdated Show resolved Hide resolved
@nguyentvan7 nguyentvan7 marked this pull request as ready for review January 21, 2024 17:33
@nguyentvan7 nguyentvan7 requested a review from lantua January 21, 2024 17:33
@nguyentvan7 nguyentvan7 merged commit 635a37d into master Jan 21, 2024
4 checks passed
@nguyentvan7 nguyentvan7 deleted the van/sro/fixDmg branch January 21, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants