Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tc opt 2 with feasibility check #1424

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Tc opt 2 with feasibility check #1424

merged 6 commits into from
Jan 17, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Jan 9, 2024 •
edited
Loading

Describe your changes

  • Add feasibility check
  • Allow min constraints for results

https://discord.com/channels/785153694478893126/1188049404217790565

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc changed the base branch from master to tc_opt_2 January 9, 2024 00:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

[sr-frontend] [Tue Jan 9 00:40:37 UTC 2024] - Building version c4d21d4

[frontend] [Tue Jan 9 00:41:02 UTC 2024] - Building version c4d21d4

[sr-frontend] [Tue Jan 9 00:42:00 UTC 2024] - Deployed c4d21d4 to https://genshin-optimizer-prs.github.io/pr/1424/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 9 00:43:09 UTC 2024] - Deployed c4d21d4 to https://genshin-optimizer-prs.github.io/pr/1424/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Jan 9 00:51:59 UTC 2024] - Building version 5274a5f

[frontend] [Tue Jan 9 00:52:26 UTC 2024] - Building version 5274a5f

[sr-frontend] [Tue Jan 9 00:53:23 UTC 2024] - Deployed 5274a5f to https://genshin-optimizer-prs.github.io/pr/1424/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 9 00:54:13 UTC 2024] - Deployed 5274a5f to https://genshin-optimizer-prs.github.io/pr/1424/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 9 21:27:04 UTC 2024] - Building version 90c1984

[sr-frontend] [Tue Jan 9 21:27:05 UTC 2024] - Building version 90c1984

[sr-frontend] [Tue Jan 9 21:28:32 UTC 2024] - Deployed 90c1984 to https://genshin-optimizer-prs.github.io/pr/1424/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 9 21:28:50 UTC 2024] - Deployed 90c1984 to https://genshin-optimizer-prs.github.io/pr/1424/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Jan 10 02:02:17 UTC 2024] - Building version d9df79d

[frontend] [Wed Jan 10 02:02:18 UTC 2024] - Building version d9df79d

[sr-frontend] [Wed Jan 10 02:03:42 UTC 2024] - Deployed d9df79d to https://genshin-optimizer-prs.github.io/pr/1424/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Jan 10 02:04:02 UTC 2024] - Deployed d9df79d to https://genshin-optimizer-prs.github.io/pr/1424/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Jan 11 07:44:40 UTC 2024] - Building version a6dea58

[sr-frontend] [Thu Jan 11 07:44:51 UTC 2024] - Building version a6dea58

[sr-frontend] [Thu Jan 11 07:46:19 UTC 2024] - Deployed a6dea58 to https://genshin-optimizer-prs.github.io/pr/1424/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Jan 17 04:38:39 UTC 2024] - Building version 88ce1a0

[sr-frontend] [Wed Jan 17 04:38:50 UTC 2024] - Building version 88ce1a0

[sr-frontend] [Wed Jan 17 04:40:27 UTC 2024] - Deployed 88ce1a0 to https://genshin-optimizer-prs.github.io/pr/1424/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Jan 17 04:40:43 UTC 2024] - Deployed 88ce1a0 to https://genshin-optimizer-prs.github.io/pr/1424/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Jan 17 04:43:50 UTC 2024] - Deleted deployment

@frzyc frzyc marked this pull request as ready for review January 17, 2024 04:37
@frzyc frzyc merged commit 3bdb2f2 into tc_opt_2 Jan 17, 2024
2 checks passed
@frzyc frzyc deleted the tc_opt_2_feasibility_check branch January 17, 2024 04:43
frzyc added a commit that referenced this pull request Jan 18, 2024
@frzyc
Tc opt 2 (#1423)
6d8e434 
* add `minSubstats` and `scalesWith`
* change from `minSubstats` to `minTotal`
* fix mintotal
* Tc opt 2 with feasibility check (#1424)
* feasibility check in solver
* fix distributed - other
* fix other roll calculation
* fix getMinSubLines
* worker hookup and UI disable when solving
* add constraints
* fix double counting issue
frzyc added a commit that referenced this pull request Jan 24, 2024
@eeeqeee @frzyc @nguyentvan7
Substat optimization on TC page (#1263)
b0b3753 
* wip: tc-opt

* fixes

* add comments

* fix hysteresis

* eslint fixes + touchups

* remove max+offset from display

* Fix apply not working & set max default to 30 subs

* wtf is teamData

i think it should call `uiDataForTeam` through
- teamData
- useTeamData
- getTeamDataCalc
- uiDataForTeam

* cleanup max+offset

* add UI to mass edit substat rolls/max

* fix bugs

* fix merge

* guard printing

* fmt

* extract to function

* hardcode answer if more distributedSubs than max

* add comment and fold ignored subs

* missed rename

* add comments

* minor fixes

* minor updates & fixes

* minor fixes

* forgot to assign the last substat

* minor refactoring

* add rarity + better max

* update roll calc

* update input

* add kqms button

* prevent all editors to trigger on 1st render

* avoid using `any` in upOpt.ts

* format

* switch to `shouldShowDevComponents`

* update initializer function for charTC

* add 2 rolls to kqms

* update default/reset rolls for charTC

* add dialogs

* use KQMS

* add gcsim snippet

* gcsim has no comma

* use raw value

* refinement

* add `minSubstats` and `scalesWith`

* change from `minSubstats` to `minTotal`

* cap

* Revert "change from `minSubstats` to `minTotal`"

This reverts commit 269cd95.

* Revert "add `minSubstats` and `scalesWith`"

This reverts commit b48b513.

* minor update

* util

* Tc opt 2 (#1423)

* add `minSubstats` and `scalesWith`
* change from `minSubstats` to `minTotal`
* fix mintotal
* Tc opt 2 with feasibility check (#1424)
* feasibility check in solver
* fix distributed - other
* fix other roll calculation
* fix getMinSubLines
* worker hookup and UI disable when solving
* add constraints
* fix double counting issue

* add unit test

* add QoL

* fix lint

* translation + bugfix

* update constraintCard

* address comments

* prevent canceling from breaking future opt runs (#1444)

* fix quotes

* addresss comments

* addresss comments

* format

* fix merge issue

---------

Co-authored-by: eeeqeee <>
Co-authored-by: frzyc <[email protected]>
Co-authored-by: Van Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frzyc