Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy tsconfig and add object-overrides global type #1407

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Tidy tsconfig and add object-overrides global type #1407

merged 1 commit into from
Jan 3, 2024

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Jan 2, 2024 •
edited
Loading

Describe your changes

  • Tidy tsconfig type
  • Add object-overrides global type that can be included for Object.entries and Object.values typing
  • Make sr-srod buildable library for later usage

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

@nguyentvan7 nguyentvan7 requested a review from frzyc January 2, 2024 19:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

[sr-frontend] [Tue Jan 2 19:21:51 UTC 2024] - Building version d1f87b2

[gi-frontend] [Tue Jan 2 19:22:01 UTC 2024] - Building version d1f87b2

[frontend] [Tue Jan 2 19:22:43 UTC 2024] - Building version d1f87b2

[sr-frontend] [Tue Jan 2 19:23:00 UTC 2024] - Deployed d1f87b2 to https://genshin-optimizer-prs.github.io/pr/1407/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Tue Jan 2 19:24:33 UTC 2024] - Deployed d1f87b2 to https://genshin-optimizer-prs.github.io/pr/1407/gi-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 2 19:25:12 UTC 2024] - Deployed d1f87b2 to https://genshin-optimizer-prs.github.io/pr/1407/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Jan 3 19:38:33 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 merged commit 2ac5566 into master Jan 3, 2024
6 checks passed
@nguyentvan7 nguyentvan7 deleted the van/sro/objOverride branch January 3, 2024 19:37
nguyentvan7 added a commit that referenced this pull request Jan 4, 2024
@kel-z @lantua
@nguyentvan7 @furrycatherder
Add SRO partial Relic adder/editor UI + misc (#1401)
5ae9927 
* Fix relic substat rounding

* Add CustomNumberInput to common lib

* Add SRO data managers exports

* Add SRO relic adder UI

* Resolve comments

* Resolve comments for real

* More sorting

* Update relic editor to show main stat val

* Update `DebugCalculator` computation (#1409)

* Tidy tsconfig and add object-overrides global type (#1407)

* Remove gi-frontend and update pipelines (#1411)

* Nuke gi-frontend

* Fix up pipelines

* Update template

* Update SRO context usage/UI issues, add useLightCone hook (#1406)

* Fix minor bugs and refactor context usage

* Add UseLightCone hook

* Unexport databasecontext

* Add remove trigger

* Add LocationAutocomplete for SRO (#1410)

* Add translation

* Fix translation

* Add LocationAutocomplete

* Fix option generation

* Update context usage

* Add debug calc for sr-formula (#1408)

* Add debug calc

* Fix lint

* Fix lint

* Fix lint

* Update debug to match gi-formula

* Add toDebug function

* update silly wisher assets to 0.33 (#1396)

* update translation table

* fix locale ordering

* update silly wisher splash art

* update silly wisher portraits

* update executor script

* update .envrc

* update the documentation

* add yaml to dev dependencies

* process i2languages in javascript executor

* add more detail to readme

* add VERSION file

* update readme

* resize splash arts

* resize portraits

* Resolve comments

---------

Co-authored-by: Van Nguyen <[email protected]>

* Add location autocomplete to relic editor

---------

Co-authored-by: lantua <[email protected]>
Co-authored-by: Van Nguyen <[email protected]>
Co-authored-by: Sean Haugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frzyc frzyc frzyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguyentvan7 @frzyc