Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eidolon datamine #1405

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Add Eidolon datamine #1405

merged 6 commits into from
Jan 4, 2024

Conversation

nguyentvan7
Copy link
Collaborator

Describe your changes

  • Add Eidolon datamine
  • Fix some key naming inconsistencies

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

@nguyentvan7 nguyentvan7 requested a review from frzyc January 2, 2024 19:17
Copy link
Contributor

github-actions bot commented Jan 2, 2024

[sr-frontend] [Tue Jan 2 19:19:22 UTC 2024] - Building version 51c5188

[sr-frontend] [Tue Jan 2 19:20:25 UTC 2024] - Deployed 51c5188 to https://genshin-optimizer-prs.github.io/pr/1405/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Jan 2 20:06:27 UTC 2024] - Building version b4eaa5e

[sr-frontend] [Tue Jan 2 20:07:38 UTC 2024] - Deployed b4eaa5e to https://genshin-optimizer-prs.github.io/pr/1405/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Jan 3 05:12:56 UTC 2024] - Building version 1ce8387

[sr-frontend] [Wed Jan 3 05:14:05 UTC 2024] - Deployed 1ce8387 to https://genshin-optimizer-prs.github.io/pr/1405/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Jan 3 20:48:43 UTC 2024] - Building version 8cc6f88

[sr-frontend] [Wed Jan 3 20:49:56 UTC 2024] - Deployed 8cc6f88 to https://genshin-optimizer-prs.github.io/pr/1405/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Thu Jan 4 03:01:47 UTC 2024] - Deleted deployment

libs/sr-formula/src/data/util/read.ts Outdated Show resolved Hide resolved
libs/sr-stats/src/executors/gen-stats/src/characterData.ts Outdated Show resolved Hide resolved
@nguyentvan7 nguyentvan7 requested a review from frzyc January 3, 2024 05:12
@nguyentvan7 nguyentvan7 requested a review from frzyc January 3, 2024 20:47
@nguyentvan7 nguyentvan7 merged commit d92b300 into master Jan 4, 2024
4 checks passed
@nguyentvan7 nguyentvan7 deleted the van/sro/eidolonDm branch January 4, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants