Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanner fix for other rarities #1371

Merged
merged 3 commits into from
Dec 18, 2023
Merged

scanner fix for other rarities #1371

merged 3 commits into from
Dec 18, 2023

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Dec 18, 2023

Describe your changes

Scanner doesn't detect other rarity(4*,3*) colors(purple, blue). Add those colors in the pipeline

Issue or discord link

Testing/validation

Example of a 3* artifact, detecting the header.
image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

@frzyc frzyc requested a review from nguyentvan7 December 18, 2023 10:00
Copy link
Contributor

github-actions bot commented Dec 18, 2023

[gi-frontend] [Mon Dec 18 10:01:20 UTC 2023] - Building version

[frontend] [Mon Dec 18 10:01:41 UTC 2023] - Building version

[sr-frontend] [Mon Dec 18 10:01:54 UTC 2023] - Building version

[sr-frontend] [Mon Dec 18 10:03:13 UTC 2023] - Deployed 3ffb281 to https://genshin-optimizer-prs.github.io/pr/1371/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Dec 18 10:03:18 UTC 2023] - Building version 0decd9d

[gi-frontend] [Mon Dec 18 10:03:19 UTC 2023] - Building version 0decd9d

[sr-frontend] [Mon Dec 18 10:04:26 UTC 2023] - Deployed 0decd9d to https://genshin-optimizer-prs.github.io/pr/1371/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Mon Dec 18 10:04:40 UTC 2023] - Deployed 3ffb281 to https://genshin-optimizer-prs.github.io/pr/1371/gi-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Dec 18 10:05:16 UTC 2023] - Deployed 3ffb281 to https://genshin-optimizer-prs.github.io/pr/1371/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Mon Dec 18 10:05:52 UTC 2023] - Deployed 0decd9d to https://genshin-optimizer-prs.github.io/pr/1371/gi-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Dec 18 17:08:35 UTC 2023] - Building version c6c80bf

[gi-frontend] [Mon Dec 18 17:08:36 UTC 2023] - Building version c6c80bf

[frontend] [Mon Dec 18 17:09:10 UTC 2023] - Building version c6c80bf

[sr-frontend] [Mon Dec 18 17:09:45 UTC 2023] - Deployed c6c80bf to https://genshin-optimizer-prs.github.io/pr/1371/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Mon Dec 18 17:11:53 UTC 2023] - Deployed c6c80bf to https://genshin-optimizer-prs.github.io/pr/1371/gi-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Dec 18 17:11:59 UTC 2023] - Deployed c6c80bf to https://genshin-optimizer-prs.github.io/pr/1371/frontend (Takes 3-5 minutes after this completes to be available)

[Mon Dec 18 17:31:59 UTC 2023] - Deleted deployment

@frzyc frzyc merged commit 08aa4a1 into master Dec 18, 2023
6 checks passed
@frzyc frzyc deleted the scanner_fix branch December 18, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants