Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change constellation header colors to blue on talent tab #1360

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

liaojh1998
Copy link
Contributor

Describe your changes

Change constellation header colors to blue on talent tab.

Testing/validation

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

[frontend] [Mon Dec 4 05:05:17 UTC 2023] - Building version

[frontend] [Mon Dec 4 05:07:44 UTC 2023] - Deployed c049024 to https://genshin-optimizer-prs.github.io/pr/1360/frontend (Takes 3-5 minutes after this completes to be available)

@@ -74,7 +74,7 @@ export default function CharacterTalentPane() {
<DropdownButton
fullWidth
title={`Constellation Lv. ${constellation}`}
color={'success'}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: color="success"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changed to color="primary"

@liaojh1998 liaojh1998 force-pushed the blue-constellation branch 2 times, most recently from 4f182be to 865ab7e Compare December 4, 2023 05:27
@frzyc frzyc merged commit 17e3a3d into frzyc:master Dec 4, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants