Fix Furina C1 Fanfare Limit #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[frontend] [Fri Dec 1 02:28:10 UTC 2023] - Building version [frontend] [Fri Dec 1 02:28:17 UTC 2023] - Building version [frontend] [Fri Dec 1 02:30:18 UTC 2023] - Deployed 1489372 to https://genshin-optimizer-prs.github.io/pr/1355/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Dec 1 02:30:26 UTC 2023] - Deployed 1489372 to https://genshin-optimizer-prs.github.io/pr/1355/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Dec 1 02:33:10 UTC 2023] - Building version b1c566e [frontend] [Fri Dec 1 02:35:26 UTC 2023] - Deployed b1c566e to https://genshin-optimizer-prs.github.io/pr/1355/frontend (Takes 3-5 minutes after this completes to be available) [Fri Dec 1 03:37:12 UTC 2023] - Deleted deployment |
PolomoPT
added
UI flaw
nguyentvan7
approved these changes
Dec 1, 2023
frzyc
pushed a commit
that referenced
this pull request
Dec 1, 2023
frzyc
added a commit
that referenced
this pull request
Dec 4, 2023
* stream changes from go-next proj to master * format * full-screen scanning feature * Generate descriptor and template file for `gi-formula` (#1351) * - Add `gi-formula:gen-file` executor - Remove `allConditionals` - Add `allListConditional` - Add `allNumConditional` - Add `conditionalEntries` - Update sheets * Typo * Typo 2: Electric Boogaloo * Commit the generated file * Prettier format gen file * Add sheet generator for #1326 (#1352) * Add sheet generator * Typo * format * add a generator for all templates * Fix format * Update readme --------- Co-authored-by: Van Nguyen <[email protected]> Co-authored-by: frzyc <[email protected]> * Misc. Sheet Issues (important Furina change) (#1350) - Apply Furina C6 unaligned DMG Increase to Arkhe and Plunge DMG. Remove Pneuma-aligned Increase from Plunge DMG. - Make Eula RES Shred a team buff. --------- Co-authored-by: Van Nguyen <[email protected]> * 9.16.4 * Fix char card not updating when switching chars (#1354) * Fix Furina C1 Fanfare Limit (#1355) * Stream changes from go-next proj to master (#1347) * stream changes from go-next proj to master * format * tsx -> ts * add location + lock button to artifact editor * format * remove file * more sensible scanned artifact defaults * more changes to artifact editor/scanning * format
frzyc
added a commit
that referenced
this pull request
Dec 18, 2023
* init nextJS app with MUI * minimal graphql NX hookup * cleanup, attach theme, update layout&page * jwt auth for graphql endpoints in backend * nextjs auto generate graphql schema * set username full path * add UID pipeline * minimal artifact pipeline * add ArtifactCard to libs * add i18n * UI lib refactoring * format * add to deploy-sro-pr * fix build * remove extra entries in tsconfig.base.json * migrate frontend to use gi-ui/theme * format * refactor ArtifactCard * add weapon/character backend -> frontend pipeline * fix circular dependency in gi-formula * update packages * add gi-formula * refactor * artifact update/removal * update cache after artifact deletion * add header * add footer * fix footer envvar * refactor weapon/char API * add artifacteditor with fullscreen scanning * stream changes from go-next proj to master * format * full-screen scanning feature * Generate descriptor and template file for `gi-formula` (#1351) * - Add `gi-formula:gen-file` executor - Remove `allConditionals` - Add `allListConditional` - Add `allNumConditional` - Add `conditionalEntries` - Update sheets * Typo * Typo 2: Electric Boogaloo * Commit the generated file * Prettier format gen file * Add sheet generator for #1326 (#1352) * Add sheet generator * Typo * format * add a generator for all templates * Fix format * Update readme * Misc. Sheet Issues (important Furina change) (#1350) - Apply Furina C6 unaligned DMG Increase to Arkhe and Plunge DMG. Remove Pneuma-aligned Increase from Plunge DMG. - Make Eula RES Shred a team buff. * 9.16.4 * Fix char card not updating when switching chars (#1354) * Fix Furina C1 Fanfare Limit (#1355) * Stream changes from go-next proj to master (#1347) * stream changes from go-next proj to master * format * tsx -> ts * add location + lock button to artifact editor * format * remove file * more sensible scanned artifact defaults * more changes to artifact editor/scanning * format * format * update artifact editor location selector * format * lint * more lint fixes * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Furina Burst cond with C1 went up to 450 Fanfare when it should cap at 400. wrong datamined value was referenced.
I am getting sloppier and sloppier with changes.
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format + lint.nx format writeto resolve them automatically.