-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify nx task graph #1333
Simplify nx task graph #1333
Conversation
Note: for sanity check, |
[frontend] [Fri Nov 10 01:20:40 UTC 2023] - Building version 138f4c6 [gi-frontend] [Fri Nov 10 01:20:59 UTC 2023] - Building version 138f4c6 [sr-frontend] [Fri Nov 10 01:21:07 UTC 2023] - Building version 138f4c6 [frontend] [Fri Nov 10 01:22:48 UTC 2023] - Deployed 138f4c6 to https://genshin-optimizer-prs.github.io/pr/1333/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Fri Nov 10 02:32:16 UTC 2023] - Building version d6dfc5f [gi-frontend] [Fri Nov 10 02:32:25 UTC 2023] - Building version d6dfc5f [frontend] [Fri Nov 10 02:32:26 UTC 2023] - Building version d6dfc5f [sr-frontend] [Fri Nov 10 02:33:24 UTC 2023] - Deployed d6dfc5f to https://genshin-optimizer-prs.github.io/pr/1333/sr-frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Fri Nov 10 02:34:54 UTC 2023] - Deployed d6dfc5f to https://genshin-optimizer-prs.github.io/pr/1333/gi-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Nov 10 02:35:22 UTC 2023] - Deployed d6dfc5f to https://genshin-optimizer-prs.github.io/pr/1333/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Nov 10 03:59:20 UTC 2023] - Building version 2d0c534 [sr-frontend] [Fri Nov 10 03:59:36 UTC 2023] - Building version 2d0c534 [gi-frontend] [Fri Nov 10 04:00:02 UTC 2023] - Building version 2d0c534 [sr-frontend] [Fri Nov 10 04:00:39 UTC 2023] - Deployed 2d0c534 to https://genshin-optimizer-prs.github.io/pr/1333/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Nov 10 04:01:30 UTC 2023] - Deployed 2d0c534 to https://genshin-optimizer-prs.github.io/pr/1333/frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Fri Nov 10 04:04:14 UTC 2023] - Deployed 2d0c534 to https://genshin-optimizer-prs.github.io/pr/1333/gi-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Nov 12 02:58:59 UTC 2023] - Building version f55c6b2 [gi-frontend] [Sun Nov 12 02:59:13 UTC 2023] - Building version f55c6b2 [frontend] [Sun Nov 12 02:59:18 UTC 2023] - Building version f55c6b2 [sr-frontend] [Sun Nov 12 03:00:07 UTC 2023] - Deployed f55c6b2 to https://genshin-optimizer-prs.github.io/pr/1333/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Nov 12 03:02:13 UTC 2023] - Deployed f55c6b2 to https://genshin-optimizer-prs.github.io/pr/1333/frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Sun Nov 12 03:02:31 UTC 2023] - Deployed f55c6b2 to https://genshin-optimizer-prs.github.io/pr/1333/gi-frontend (Takes 3-5 minutes after this completes to be available) [Sun Nov 12 05:27:16 UTC 2023] - Deleted deployment |
Add some wiki on the current nx task graph structure: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe your changes
House cleaning on nx graph.
Barring unique tasks, we should have 4 main "stages":
serve
,build
,genFile
,load-dm
.build <- genFile <- load-dm
serve <- genFile <- load-dm
TODO list:
serve
depend onbuild
pipeline
task (should all begenFile
genFile
togen-file
Issue or discord link
Resolves #1325
Testing/validation
Updated
build
Updated
serve
Updated wiki:
https://github.com/frzyc/genshin-optimizer/wiki/Notes-on-nx-configuration
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format + lint.nx format write
to resolve them automatically.