Resolve comments

frzyc · Jan 16, 2025 · a35a4d0 · a35a4d0
1 parent ad1c11a
commit a35a4d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/libs/common/ui/src/components/NumberInputLazy.tsx b/libs/common/ui/src/components/NumberInputLazy.tsx
@@ -23,9 +23,9 @@ export function NumberInputLazy({
   useEffect(() => {
     setValue(valueProp?.toString())
   }, [valueProp])
-  const normalizedValue = float ? value.replace(',', '.') : value
 
   const saveValue = () => {
+    const normalizedValue = float ? value.replace(',', '.') : value
     let num = float ? parseFloat(normalizedValue) : parseInt(normalizedValue)
     if (isNaN(num)) {
       num = 0

diff --git a/libs/gi/ui/src/components/artifact/editor/index.tsx b/libs/gi/ui/src/components/artifact/editor/index.tsx
@@ -651,6 +651,7 @@ export function ArtifactEditor({
                             >
                               {t('editor.uploadBtn')}
                             </Button>
+                            {/* https://github.com/frzyc/genshin-optimizer/pull/2597 */}
                             <LineBreak />
                           </label>
                         </Grid>