Refactor code

frzyc · Jan 25, 2025 · 807fb42 · 807fb42
1 parent a91a98c
commit 807fb42
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/libs/gi/localization/assets/locales/en/artifact.json b/libs/gi/localization/assets/locales/en/artifact.json
@@ -124,5 +124,5 @@
   },
   "builds_one": "{{count}} Build",
   "builds_other": "{{count}} Builds",
-  "usage": "Used in: "
+  "artifactUsage": "Artifact is used in the following builds: "
 }
diff --git a/libs/gi/ui/src/components/artifact/ArtifactCard.tsx b/libs/gi/ui/src/components/artifact/ArtifactCard.tsx
@@ -45,8 +45,10 @@ import {
   CardContent,
   CardHeader,
   Chip,
-  Divider,
   IconButton,
+  List,
+  ListItem,
+  ListItemText,
   Skeleton,
   SvgIcon,
   Typography,
@@ -196,7 +198,8 @@ export function ArtifactCardObj({
         <ArtifactBuildUsageModal
           show={showUsage}
           onHide={onHideUsage}
-          buildNames={t('artifact:usage') + buildNames.join(', ')}
+          buildNames={buildNames}
+          usageText={t('artifact:artifactUsage')}
         />
       </Suspense>
       <CardThemed
@@ -532,10 +535,12 @@ function ArtifactBuildUsageModal({
   show,
   onHide,
   buildNames,
+  usageText,
 }: {
   show: boolean
   onHide: () => void
-  buildNames: string
+  buildNames: string[]
+  usageText: string
 }) {
   return (
     <ModalWrapper open={show} onClose={onHide}>
@@ -548,7 +553,7 @@ function ArtifactBuildUsageModal({
               display="flex"
               alignItems="center"
             >
-              {buildNames}
+              {usageText}
             </Typography>
           }
           action={
@@ -557,7 +562,13 @@ function ArtifactBuildUsageModal({
             </IconButton>
           }
         />
-        <Divider />
+        <List>
+          {buildNames.map((name, index) => (
+            <ListItem key={index}>
+              <ListItemText primary={name} />
+            </ListItem>
+          ))}
+        </List>
       </CardThemed>
     </ModalWrapper>
   )