Skip to content

Commit

Permalink
Add comments for srsim splits
Browse files Browse the repository at this point in the history
  • Loading branch information
nguyentvan7 committed Jan 1, 2024
1 parent c0d4a55 commit 3badff1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion libs/sr-formula/src/data/char/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function scalingParams(data_gen: CharacterDataGen) {
* @param stat Stat that the damage scales on
* @param levelScaling Array representing the scaling at different levels of the ability
* @param abilityScalingType Ability level that the scaling depends on
* @param splits Array of decimals that should add up to 1. Each entry represents the percentage of damage that hit deals, for multi-hit moves
* @param splits Array of decimals that should add up to 1. Each entry represents the percentage of damage that hit deals, for multi-hit moves. We get splits from SRSim devs, see the array at the top of https://github.com/simimpact/srsim/blob/main/internal/character/march7th/ult.go for example.
* @param overrideAttackType Type of attack damage that is dealt, only need to set if it deals a different damage type than abilityScalingType, or if abilityScalingType is Talent
* @param arg
* @param extra Buffs that should only apply to this damage instance
Expand Down
2 changes: 1 addition & 1 deletion libs/sr-formula/src/data/util/sheet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export function listingItem(t: Read, cond?: string | StrNode) {
* @param name Base name to be used as the key
* @param type Type of the damage
* @param AttackType Type of attack damage that is dealt
* @param splits Array of decimals that should add up to 1. Each entry represents the percentage of damage that hit deals, for multi-hit moves
* @param splits Array of decimals that should add up to 1. Each entry represents the percentage of damage that hit deals, for multi-hit moves. We get splits from SRSim devs, see the array at the top of https://github.com/simimpact/srsim/blob/main/internal/character/march7th/ult.go for example.
* @param arg
* @param extra Buffs that should only apply to this damage instance
* @returns Array of TagMapNodeEntries representing the damage instance
Expand Down

0 comments on commit 3badff1

Please sign in to comment.