New Modules #60
Open
New Modules #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 22, 2024 16:47
frasdav
reviewed
Jan 22, 2024
modules/linux-web-app/README.md
Outdated
| @@ -0,0 +1,32 @@ | |||
| # Data Factory | |||
There was a problem hiding this comment.
Suggested change
| # Data Factory | |
| # Linux Web App |
modules/linux-web-app/README.md
Outdated
Comment on lines
11
to
18
| environment = "dev" | ||
| identifier = "mortgages" | ||
| location = "uksouth" | ||
| log_analytics_workspace_id = data.azurerm_log_analytics_workspace.main.id | ||
| resource_group_name = module.resource_group.name | ||
| service_plan_id = module.app_service_plan.id | ||
| instrumentation_key = azurerm_application_insights.main.instrumentation_key | ||
| zone = "mtg" |
There was a problem hiding this comment.
Convention is to keep the 5 standard vars together and then the rest below.
Suggested change
| environment = "dev" | |
| identifier = "mortgages" | |
| location = "uksouth" | |
| log_analytics_workspace_id = data.azurerm_log_analytics_workspace.main.id | |
| resource_group_name = module.resource_group.name | |
| service_plan_id = module.app_service_plan.id | |
| instrumentation_key = azurerm_application_insights.main.instrumentation_key | |
| zone = "mtg" | |
| environment = "dev" | |
| identifier = "mortgages" | |
| location = "uksouth" | |
| resource_group_name = module.resource_group.name | |
| zone = "mtg" | |
| service_plan_id = module.app_service_plan.id | |
| instrumentation_key = azurerm_application_insights.main.instrumentation_key | |
| log_analytics_workspace_id = data.azurerm_log_analytics_workspace.main.id |
modules/linux-web-app/src/main.tf
Outdated
| name = "log-analytics" | ||
| target_resource_id = azurerm_linux_web_app.main.id | ||
| log_analytics_workspace_id = var.log_analytics_workspace_id | ||
| log_analytics_destination_type = "AzureDiagnostics" |
There was a problem hiding this comment.
This causes TF to flap.
Suggested change
| log_analytics_destination_type = "AzureDiagnostics" |
modules/cosmosdb-account/README.md
Outdated
| @@ -0,0 +1,29 @@ | |||
| # Data Factory | |||
There was a problem hiding this comment.
Suggested change
| # Data Factory | |
| # CosmosDB Account |
modules/service-plan/README.md
Outdated
Comment on lines
11
to
17
| environment = "dev" | ||
| identifier = "mortgages" | ||
| location = "uksouth" | ||
| os_type = "Linux" | ||
| resource_group_name = module.resource_group.name | ||
| sku_name = "P0v3" | ||
| zone = "mtg" |
There was a problem hiding this comment.
Suggested change
| environment = "dev" | |
| identifier = "mortgages" | |
| location = "uksouth" | |
| os_type = "Linux" | |
| resource_group_name = module.resource_group.name | |
| sku_name = "P0v3" | |
| zone = "mtg" | |
| environment = "dev" | |
| identifier = "mortgages" | |
| location = "uksouth" | |
| resource_group_name = module.resource_group.name | |
| zone = "mtg" | |
| os_type = "Linux" | |
| sku_name = "P0v3" |
modules/service-plan/README.md
Outdated
|
|
||
| ```hcl | ||
| module "service_plan" { | ||
| source = "https://github.com/gofrontier-com/azurerm-terraform-modules/releases/download/app-service-plan/[VERSION]/module.tar.gz//src" |
There was a problem hiding this comment.
Suggested change
| source = "https://github.com/gofrontier-com/azurerm-terraform-modules/releases/download/app-service-plan/[VERSION]/module.tar.gz//src" | |
| source = "https://github.com/gofrontier-com/azurerm-terraform-modules/releases/download/service-plan/[VERSION]/module.tar.gz//src" |
modules/service-plan/test/main.tf
Outdated
| features {} | ||
| } | ||
|
|
||
| module "app_service_plan" { |
There was a problem hiding this comment.
Suggested change
| module "app_service_plan" { | |
| module "service_plan" { |
modules/service-plan/test/main.tf
Outdated
Comment on lines
8
to
14
| environment = "bar" | ||
| identifier = "baz" | ||
| location = "uksouth" | ||
| os_type = "boo" | ||
| resource_group_name = "bar" | ||
| sku_name = "far" | ||
| zone = "bat" |
There was a problem hiding this comment.
Suggested change
| environment = "bar" | |
| identifier = "baz" | |
| location = "uksouth" | |
| os_type = "boo" | |
| resource_group_name = "bar" | |
| sku_name = "far" | |
| zone = "bat" | |
| environment = "bar" | |
| identifier = "baz" | |
| location = "uksouth" | |
| resource_group_name = "bar" | |
| zone = "bat" | |
| os_type = "boo" | |
| sku_name = "far" |
Co-authored-by: Fraser Davidson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.